[Buildroot] [PATCH] package/shairport-sync: bump to version 2.8.5

[Buildroot] [PATCH] package/shairport-sync: bump to version 2.8.5

[Jörg Krause]

In version 2.8.5 the default value for sysconfdir is changed to
`/usr/local/etc`. As `/etc` is normally used in Linux and to retain the
previous behaviour pass `--sysconfdir=/etc` to the configuration
environment.

Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/shairport-sync/shairport-sync.hash | 2 +-
 package/shairport-sync/shairport-sync.mk   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/shairport-sync/shairport-sync.hash b/package/shairport-sync/shairport-sync.hash
index 907a71e..dfe0d05 100644
--- a/package/shairport-sync/shairport-sync.hash
+++ b/package/shairport-sync/shairport-sync.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256  80dd94c5f37b43e9b157dd5335f8edaf11109859d0144e0046c7b86fe88f6547  shairport-sync-2.8.4.tar.gz
+sha256  d19f6cd3d53f5010abcf24cc20a301934372b41efc3ff2a2e4e7d8fa49200cdc  shairport-sync-2.8.5.tar.gz
diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk
index 49c6604..1d0b863 100644
--- a/package/shairport-sync/shairport-sync.mk
+++ b/package/shairport-sync/shairport-sync.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SHAIRPORT_SYNC_VERSION = 2.8.4
+SHAIRPORT_SYNC_VERSION = 2.8.5
 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
 
 SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
@@ -17,7 +17,8 @@ SHAIRPORT_SYNC_AUTORECONF = YES
 SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
 	--with-metadata \
 	--with-pipe \
-	--with-stdout
+	--with-stdout \
+	--sysconfdir=/etc
 
 # Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns).
 # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon
-- 
2.10.0

[Buildroot] [PATCH] package/shairport-sync: bump to version 2.8.5

[Thomas Petazzoni]

Hello,

On Tue, 11 Oct 2016 22:07:32 +0200, J?rg Krause wrote:

>  SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
> @@ -17,7 +17,8 @@ SHAIRPORT_SYNC_AUTORECONF = YES
>  SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
>  	--with-metadata \
>  	--with-pipe \
> -	--with-stdout
> +	--with-stdout \
> +	--sysconfdir=/etc

We are already passing --sysconfdir=/etc globally to all autoconf based
packages, in package/pkg-autotools.mk, so this should not be necessary.

Do you really see things installed in /usr/local/etc ? Why isn't the
global --sysconfdir passed by pkg-autotools.mk not working ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] package/shairport-sync: bump to version 2.8.5

[Jörg Krause]

Hi Thomas,

On Mi, 2016-10-12 at 13:57 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 11 Oct 2016 22:07:32 +0200, J?rg Krause wrote:
> 
> > 
> > ?SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
> > @@ -17,7 +17,8 @@ SHAIRPORT_SYNC_AUTORECONF = YES
> > ?SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
> > ?	--with-metadata \
> > ?	--with-pipe \
> > -	--with-stdout
> > +	--with-stdout \
> > +	--sysconfdir=/etc
> 
> We are already passing --sysconfdir=/etc globally to all autoconf
> based
> packages, in package/pkg-autotools.mk, so this should not be
> necessary.

I see!

> Do you really see things installed in /usr/local/etc ? Why isn't the
> global --sysconfdir passed by pkg-autotools.mk not working ?

To be honest, I only checked that passing sysconfdir locally is working
as I didn't know that it is passed globally. So I will remove this
setting in v2.

Thanks!

Best regards
J?rg Krause

[Buildroot] [PATCH] package/shairport-sync: bump to version 2.8.5

[Thomas Petazzoni]

Hello,

On Wed, 12 Oct 2016 14:02:36 +0200, J?rg Krause wrote:

> > Do you really see things installed in /usr/local/etc ? Why isn't the
> > global --sysconfdir passed by pkg-autotools.mk not working ?  
> 
> To be honest, I only checked that passing sysconfdir locally is working
> as I didn't know that it is passed globally. So I will remove this
> setting in v2.

Great, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com