From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Report from the Buildroot Meeting in Berlin
Date: Mon, 24 Oct 2016 16:57:10 +0200 [thread overview]
Message-ID: <20161024165710.652d270a@free-electrons.com> (raw)
In-Reply-To: <bf335e58-9056-4b66-6c07-6b5e0570eaa7@imgtec.com>
Hello,
On Mon, 24 Oct 2016 15:52:27 +0100, Vicente Olivert Riera wrote:
> I proposed basically the same idea on IRC few days ago, but instead of
> checking an env variable I was proposing to add an option to the wrapper
> in order to switch which flags should be used.
An option doesn't work, because it can easily be "lost" by the package
build system. An environment variable is much more difficult to loose.
> You didn't like the idea because "it's hard to distinguish between
> 'kernel-like' and 'userspace-like' packages" and because "you want to be
> able to use the buildroot-generated toolchain to build a kernel
> externally, without adding hacks".
>
> I'm confused. With Thomas proposal you will need to declare that env
> variable if you want to be able to build a kernel with that
> buildroot-generated toolchain. That's a hack similar as adding an option
> called -foo, for instance.
>
> Plus, I don't see how the problem of distinguishing between
> 'kernel-like' and 'userspace-like' package is solved if we use an env
> variable instead of an option.
>
> I'm not saying that I don't like Thomas proposal. I do like it, and in
> fact, probably is cleaner than adding an option to the wrapper. What I
> don't understand is that you said you didn't like my idea due to those
> two reasons, and now you say that you "kind of like" Thomas' idea which
> (I think) still has the same issues as mine ('kernel-like' and
> 'userspace-like' packages distinguishing plus buildroot-generated
> toolchain reuse without hacks).
>
> Am I missing something here?
You're probably just missing the fact that we are discussing, trying to
find approaches. Which means we sometimes contradict ourselves, go back
to previous proposals that were not considered good originally, etc.
But yes, you're right: the fact that the wrapper is not usable as-is to
build a Linux kernel or a bootloader outside of Buildroot without
passing some weird option or environment variable makes my proposal
not appealing at all.
Shouldn't we bite the bullet and stop doing shit with this wrapper? I.e
only make it pass the absolutely mandatory --sysroot option but not
other option whatsoever. Yes, this means potentially fixing broken
package build system, but if that's the right thing to do?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-24 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 20:10 [Buildroot] Report from the Buildroot Meeting in Berlin Thomas Petazzoni
2016-10-20 16:39 ` Arnout Vandecappelle
2016-10-21 8:25 ` Thomas Petazzoni
2016-10-21 8:57 ` Arnout Vandecappelle
2016-10-21 9:05 ` Thomas Petazzoni
2016-10-24 12:02 ` Peter Korsgaard
2016-10-24 12:19 ` Vicente Olivert Riera
2016-10-24 12:28 ` Thomas Petazzoni
2016-10-24 13:05 ` Arnout Vandecappelle
2016-10-24 14:52 ` Vicente Olivert Riera
2016-10-24 14:57 ` Thomas Petazzoni [this message]
2016-10-24 15:47 ` [Buildroot] Toolchain wrapper CFLAGS [was: Re: Report from the Buildroot Meeting in Berlin] Arnout Vandecappelle
2016-10-24 12:39 ` [Buildroot] Report from the Buildroot Meeting in Berlin Peter Korsgaard
2016-10-24 0:54 ` Sam Bobroff
2016-10-24 7:25 ` Thomas Petazzoni
2016-10-25 2:21 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024165710.652d270a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox