Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] lttng-libust: bump to version 2.8.1
Date: Sun, 30 Oct 2016 16:50:16 +0100	[thread overview]
Message-ID: <20161030165016.06b121eb@free-electrons.com> (raw)
In-Reply-To: <20161029180339.24535-2-eeppeliteloop@gmail.com>

Hello,

On Sat, 29 Oct 2016 14:03:35 -0400, Philippe Proulx wrote:
> Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>

It would be great to not have an empty commit log here. In fact, you
included a lot of information in your cover letter, but the cover
letter contents is not part of any Git commit, so it isn't present in
the Git history.

So please transfer more details about the different patches in the
description of each patch. Thanks.

> ---
>  ...lf.c-define-NT_GNU_BUILD_ID-if-not-define.patch | 31 ++++++++++++++++++++++
>  package/lttng-libust/lttng-libust.hash             | 12 +++++----
>  package/lttng-libust/lttng-libust.mk               | 10 +++----
>  3 files changed, 42 insertions(+), 11 deletions(-)
>  create mode 100644 package/lttng-libust/0001-lttng-ust-elf.c-define-NT_GNU_BUILD_ID-if-not-define.patch

This patch looks good, but I'm going to wait for the entire series to
be ready before applying them. See below one question, though.

> diff --git a/package/lttng-libust/0001-lttng-ust-elf.c-define-NT_GNU_BUILD_ID-if-not-define.patch b/package/lttng-libust/0001-lttng-ust-elf.c-define-NT_GNU_BUILD_ID-if-not-define.patch
> new file mode 100644
> index 0000000..7fc2148
> --- /dev/null
> +++ b/package/lttng-libust/0001-lttng-ust-elf.c-define-NT_GNU_BUILD_ID-if-not-define.patch
> @@ -0,0 +1,31 @@
> +From d400314757a8d5d52bd5722d263bfd5886bb6595 Mon Sep 17 00:00:00 2001
> +From: Philippe Proulx <eeppeliteloop@gmail.com>
> +Date: Sat, 29 Oct 2016 13:32:57 -0400
> +Subject: [PATCH] lttng-ust-elf.c: define NT_GNU_BUILD_ID if not defined
> +
> +On uClibc, NT_GNU_BUILD_ID is not defined, so we define it
> +manually in this case.

Did you submit this patch upstream?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-10-30 15:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29 18:03 [Buildroot] [PATCH 0/5] Update LTTng packages to 2.8.x and Babeltrace to 1.4.0 Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 1/5] lttng-libust: bump to version 2.8.1 Philippe Proulx
2016-10-30 15:50   ` Thomas Petazzoni [this message]
2016-10-29 18:03 ` [Buildroot] [PATCH 2/5] lttng-tools: bump to version 2.8.2 Philippe Proulx
2016-10-30 16:13   ` Thomas Petazzoni
2016-10-30 17:33     ` Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 3/5] lttng-tools: remove dependency on host-lttng-babeltrace Philippe Proulx
2016-10-30 16:16   ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 4/5] lttng-modules: bump to version 2.8.3 Philippe Proulx
2016-10-30 16:15   ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 5/5] lttng-babeltrace: bump to version 1.4.0 Philippe Proulx
2016-10-30 16:18   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030165016.06b121eb@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox