From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] lttng-babeltrace: bump to version 1.4.0
Date: Sun, 30 Oct 2016 17:18:41 +0100 [thread overview]
Message-ID: <20161030171841.7e58ddee@free-electrons.com> (raw)
In-Reply-To: <20161029180339.24535-6-eeppeliteloop@gmail.com>
Hello,
On Sat, 29 Oct 2016 14:03:39 -0400, Philippe Proulx wrote:
> Also: remove the host package. Users can get Babeltrace on major
> Linux distributions.
Please improve the commit log with details about the different patches
being removed/added.
> new file mode 100644
> index 0000000..1885526
> --- /dev/null
> +++ b/package/lttng-babeltrace/0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch
> @@ -0,0 +1,25 @@
> +From d3cce60dfde30bd2fd67caa3fbc5f111131c243a Mon Sep 17 00:00:00 2001
> +From: Philippe Proulx <eeppeliteloop@gmail.com>
> +Date: Fri, 28 Oct 2016 01:48:25 -0400
> +Subject: [PATCH] configure.ac: remove elfutils version test for Buildroot
Why? Is this version check causing a problem?
> diff --git a/package/lttng-babeltrace/0002-tests-lib-Makefile.am-remove-unneeded-static-flag.patch b/package/lttng-babeltrace/0002-tests-lib-Makefile.am-remove-unneeded-static-flag.patch
> new file mode 100644
> index 0000000..3a8e154
> --- /dev/null
> +++ b/package/lttng-babeltrace/0002-tests-lib-Makefile.am-remove-unneeded-static-flag.patch
> @@ -0,0 +1,31 @@
> +From 27e37d2621317d25e08ba0683bf8540b05b9347d Mon Sep 17 00:00:00 2001
> +From: Philippe Proulx <eeppeliteloop@gmail.com>
> +Date: Fri, 28 Oct 2016 02:09:20 -0400
> +Subject: [PATCH] tests/lib/Makefile.am: remove unneeded -static flag
> +
> +Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Please explain why it is unneeded and why we want to remove it. I know
why: it's because it breaks the build in shared-only builds. But it
should be explained here as well.
Do you think it can be accepted upstream?
> -HOST_LTTNG_BABELTRACE_DEPENDENCIES = \
> - host-popt host-util-linux host-libglib2 host-pkgconf
> -
> -# for 0002-configure-fix-uuid-support-detection-on-static-build.patch
> LTTNG_BABELTRACE_AUTORECONF = YES
Please keep a comment above this line that explains why it is needed.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-10-30 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 18:03 [Buildroot] [PATCH 0/5] Update LTTng packages to 2.8.x and Babeltrace to 1.4.0 Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 1/5] lttng-libust: bump to version 2.8.1 Philippe Proulx
2016-10-30 15:50 ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 2/5] lttng-tools: bump to version 2.8.2 Philippe Proulx
2016-10-30 16:13 ` Thomas Petazzoni
2016-10-30 17:33 ` Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 3/5] lttng-tools: remove dependency on host-lttng-babeltrace Philippe Proulx
2016-10-30 16:16 ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 4/5] lttng-modules: bump to version 2.8.3 Philippe Proulx
2016-10-30 16:15 ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 5/5] lttng-babeltrace: bump to version 1.4.0 Philippe Proulx
2016-10-30 16:18 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030171841.7e58ddee@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox