From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES
Date: Tue, 1 Nov 2016 15:37:01 +0100 [thread overview]
Message-ID: <20161101153701.04acd1d2@free-electrons.com> (raw)
In-Reply-To: <20161101140933.859-1-kraai@ftbfs.org>
Hello,
On Tue, 1 Nov 2016 07:09:32 -0700, Matt Kraai wrote:
> Signed-off-by: Matt Kraai <kraai@ftbfs.org>
> ---
> package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------
> 1 file changed, 6 deletions(-)
Rather than removing these, we should instead make it consistent with
what qt5engineio is doing, i.e install those examples. See
qt5engineio.mk.
Could you rework your patches accordingly?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-01 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 14:09 [Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES Matt Kraai
2016-11-01 14:09 ` [Buildroot] [PATCH 2/2] qt5websockets: remove QT5WEBSOCKETS_INSTALL_TARGET_EXAMPLES Matt Kraai
2016-11-01 14:37 ` Thomas Petazzoni [this message]
2016-11-01 14:57 ` [Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101153701.04acd1d2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox