[Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES

[Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES

[Matt Kraai]

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
---
 package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/qt5/qt5webchannel/qt5webchannel.mk b/package/qt5/qt5webchannel/qt5webchannel.mk
index 9e94914..316b8e0 100644
--- a/package/qt5/qt5webchannel/qt5webchannel.mk
+++ b/package/qt5/qt5webchannel/qt5webchannel.mk
@@ -46,12 +46,6 @@ define QT5WEBCHANNEL_INSTALL_TARGET_QMLS
 endef
 endif
 
-ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
-define QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES
-	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/webchannel $(TARGET_DIR)/usr/lib/qt/examples/
-endef
-endif
-
 ifneq ($(BR2_STATIC_LIBS),y)
 define QT5WEBCHANNEL_INSTALL_TARGET_LIBS
 	cp -dpf $(STAGING_DIR)/usr/lib/libQt5WebChannel.so.* $(TARGET_DIR)/usr/lib
-- 
2.10.2

[Buildroot] [PATCH 2/2] qt5websockets: remove QT5WEBSOCKETS_INSTALL_TARGET_EXAMPLES

[Matt Kraai]

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
---
 package/qt5/qt5websockets/qt5websockets.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/qt5/qt5websockets/qt5websockets.mk b/package/qt5/qt5websockets/qt5websockets.mk
index f1200c2..9e4c850 100644
--- a/package/qt5/qt5websockets/qt5websockets.mk
+++ b/package/qt5/qt5websockets/qt5websockets.mk
@@ -41,12 +41,6 @@ define QT5WEBSOCKETS_INSTALL_TARGET_QMLS
 endef
 endif
 
-ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
-define QT5WEBSOCKETS_INSTALL_TARGET_EXAMPLES
-	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/websockets $(TARGET_DIR)/usr/lib/qt/examples/
-endef
-endif
-
 ifneq ($(BR2_STATIC_LIBS),y)
 define QT5WEBSOCKETS_INSTALL_TARGET_LIBS
 	cp -dpf $(STAGING_DIR)/usr/lib/libQt5WebSockets.so.* $(TARGET_DIR)/usr/lib
-- 
2.10.2

[Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES

[Thomas Petazzoni]

Hello,

On Tue,  1 Nov 2016 07:09:32 -0700, Matt Kraai wrote:
> Signed-off-by: Matt Kraai <kraai@ftbfs.org>
> ---
>  package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------
>  1 file changed, 6 deletions(-)

Rather than removing these, we should instead make it consistent with
what qt5engineio is doing, i.e install those examples. See
qt5engineio.mk.

Could you rework your patches accordingly?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] qt5webchannel: remove QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES

[Matt Kraai]

Hi,

On Tue, Nov 01, 2016 at 03:37:01PM +0100, Thomas Petazzoni wrote:
> On Tue,  1 Nov 2016 07:09:32 -0700, Matt Kraai wrote:
> > Signed-off-by: Matt Kraai <kraai@ftbfs.org>
> > ---
> >  package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------
> >  1 file changed, 6 deletions(-)
> 
> Rather than removing these, we should instead make it consistent with
> what qt5engineio is doing, i.e install those examples. See
> qt5engineio.mk.
> 
> Could you rework your patches accordingly?

I've sent updated patches.  Thank you for the suggestion on a better
approach.

-- 
Matt                                           https://ftbfs.org/~kraai/