[Buildroot] [PATCH 1/2] python: improve reproducability

[Buildroot] [PATCH 1/2] python: improve reproducability

[Danomi Manchego]

The readline and hashlib options work simply by adding dependencies;
there is no specific configure switch for them.  Therefore, if those
external dependencies are selected independent of python, then they
can affect its compilation.  So if those packages are selected outside
of python, make them go first.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/python/python.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/python/python.mk b/package/python/python.mk
index cc65376..8c51d23 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -60,7 +60,7 @@ HOST_PYTHON_DEPENDENCIES = host-expat host-zlib
 
 PYTHON_INSTALL_STAGING = YES
 
-ifeq ($(BR2_PACKAGE_PYTHON_READLINE),y)
+ifneq ($(BR2_PACKAGE_PYTHON_READLINE)$(BR2_PACKAGE_READLINE),)
 PYTHON_DEPENDENCIES += readline
 endif
 
@@ -120,7 +120,7 @@ else
 PYTHON_CONF_OPTS += --disable-zlib
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON_HASHLIB),y)
+ifneq ($(BR2_PACKAGE_PYTHON_HASHLIB)$(BR2_PACKAGE_OPENSSL),)
 PYTHON_DEPENDENCIES += openssl
 endif
 
-- 
1.9.1

[Buildroot] [PATCH 2/2] python3: improve reproducability

[Danomi Manchego]

The readline, ssl, bzip2, xz, and zlip options work simply by adding
dependencies; there is no specific configure switch for them.  Therefore,
if those external dependencies are selected independent of python3, then
they can affect its compilation.  So if those packages are selected outside
of python3, make them go first.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/python3/python3.mk | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/python3/python3.mk b/package/python3/python3.mk
index b3f31c0..93c0962 100644
--- a/package/python3/python3.mk
+++ b/package/python3/python3.mk
@@ -53,7 +53,7 @@ HOST_PYTHON3_DEPENDENCIES = host-expat host-zlib
 
 PYTHON3_INSTALL_STAGING = YES
 
-ifeq ($(BR2_PACKAGE_PYTHON3_READLINE),y)
+ifneq ($(BR2_PACKAGE_PYTHON3_READLINE)$(BR2_PACKAGE_READLINE),)
 PYTHON3_DEPENDENCIES += readline
 endif
 
@@ -87,7 +87,7 @@ else
 PYTHON3_CONF_OPTS += --disable-sqlite3
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON3_SSL),y)
+ifneq ($(BR2_PACKAGE_PYTHON3_SSL)$(BR2_PACKAGE_OPENSSL),)
 PYTHON3_DEPENDENCIES += openssl
 endif
 
@@ -99,15 +99,15 @@ ifneq ($(BR2_PACKAGE_PYTHON3_UNICODEDATA),y)
 PYTHON3_CONF_OPTS += --disable-unicodedata
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON3_BZIP2),y)
+ifneq ($(BR2_PACKAGE_PYTHON3_BZIP2)$(BR2_PACKAGE_BZIP2),)
 PYTHON3_DEPENDENCIES += bzip2
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON3_XZ),y)
+ifneq ($(BR2_PACKAGE_PYTHON3_XZ)$(BR2_PACKAGE_XZ),)
 PYTHON3_DEPENDENCIES += xz
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON3_ZLIB),y)
+ifneq ($(BR2_PACKAGE_PYTHON3_ZLIB)$(BR2_PACKAGE_ZLIB),)
 PYTHON3_DEPENDENCIES += zlib
 endif
 
-- 
1.9.1

[Buildroot] [PATCH 1/2] python: improve reproducability

[Thomas Petazzoni]

Hello,

On Thu,  3 Nov 2016 21:29:30 -0400, Danomi Manchego wrote:
> The readline and hashlib options work simply by adding dependencies;
> there is no specific configure switch for them.  Therefore, if those
> external dependencies are selected independent of python, then they
> can affect its compilation.  So if those packages are selected outside
> of python, make them go first.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/python/python.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/python/python.mk b/package/python/python.mk
> index cc65376..8c51d23 100644
> --- a/package/python/python.mk
> +++ b/package/python/python.mk
> @@ -60,7 +60,7 @@ HOST_PYTHON_DEPENDENCIES = host-expat host-zlib
>  
>  PYTHON_INSTALL_STAGING = YES
>  
> -ifeq ($(BR2_PACKAGE_PYTHON_READLINE),y)
> +ifneq ($(BR2_PACKAGE_PYTHON_READLINE)$(BR2_PACKAGE_READLINE),)
>  PYTHON_DEPENDENCIES += readline
>  endif

I understand the problem, but I don't really like the solution. Indeed,
when BR2_PACKAGE_PYTHON_READLINE is disabled, I expect readline support
to not be enabled in Python, regardless of whether BR2_PACKAGE_READLINE
is enabled or not. Perhaps we should add the relevant
--enable/--disable options, like we have for various other Python
optional dependencies?

Otherwise, we could just as well remove those options altogether.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com