Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pseudo: fix build for python3 based distros
Date: Sat, 5 Nov 2016 13:39:51 +0100	[thread overview]
Message-ID: <20161105123951.GE31560@free.fr> (raw)
In-Reply-To: <20161105035549.18698-2-gael.portay@savoirfairelinux.com>

Ga?l, All,

On 2016-11-04 23:55 -0400, Ga?l PORTAY spake thusly:
> Pseudo is not python3 friendly. It causes build failure on distros using
> python3 as default python interpretor.
> 
> ./maketables enums/*.in
>   File "./makewrappers", line 327
>     return """/* This function is not called if pseudo is configured --enable-force-async */
>                                                                                            ^
> TabError: inconsistent use of tabs and spaces in indentation
>   File "./maketables", line 76
>     print "Flags: set for %s" % self.name
>                             ^
> SyntaxError: Missing parentheses in call to 'print'
> make[2]: *** [Makefile:150: wrappers] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile:147: tables] Error 1
> 
> Those patches make pseudo works with python2 and python3.
> 
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>

My python is python2, and it still work.

Then I switched 'python' to 'python3' as the interpreter to use in both
scripts, and it indeed work too.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-11-05 12:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05  3:55 [Buildroot] pseudo: fix build for python3 based distros Gaël PORTAY
2016-11-05  3:55 ` [Buildroot] [PATCH] " Gaël PORTAY
2016-11-05 12:39   ` Yann E. MORIN [this message]
2016-11-05 13:47     ` Gaël PORTAY
2016-11-05 12:43   ` Thomas Petazzoni
2016-11-05 13:43     ` Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161105123951.GE31560@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox