From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pseudo: fix build for python3 based distros
Date: Sat, 5 Nov 2016 09:43:54 -0400 [thread overview]
Message-ID: <20161105134352.GA26483@archlinux> (raw)
In-Reply-To: <20161105134305.463e1cc2@free-electrons.com>
Hi,
On Sat, Nov 05, 2016 at 01:43:05PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 4 Nov 2016 23:55:49 -0400, Ga?l PORTAY wrote:
> > Pseudo is not python3 friendly. It causes build failure on distros using
> > python3 as default python interpretor.
> >
> > ./maketables enums/*.in
> > File "./makewrappers", line 327
> > return """/* This function is not called if pseudo is configured --enable-force-async */
> > ^
> > TabError: inconsistent use of tabs and spaces in indentation
> > File "./maketables", line 76
> > print "Flags: set for %s" % self.name
> > ^
> > SyntaxError: Missing parentheses in call to 'print'
> > make[2]: *** [Makefile:150: wrappers] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[2]: *** [Makefile:147: tables] Error 1
> >
> > Those patches make pseudo works with python2 and python3.
> >
> > Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> > ---
> > .../0001-Fix-mixed-tab-space-indentation.patch | 105 ++++++++++
> > .../0002-Fix-missing-parentheses-at-print.patch | 190 ++++++++++++++++++
> > .../0003-Make-it-compatible-with-python3.patch | 215 +++++++++++++++++++++
> > 3 files changed, 510 insertions(+)
> > create mode 100644 package/pseudo/0001-Fix-mixed-tab-space-indentation.patch
> > create mode 100644 package/pseudo/0002-Fix-missing-parentheses-at-print.patch
> > create mode 100644 package/pseudo/0003-Make-it-compatible-with-python3.patch
>
> Applied to master, thanks. My understanding is that you are already in
> touch with upstream to get them merged, right?
>
Okay, perfect. Thanks!
Indeed, I am in touch with Seebs. He is in cc.
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
prev parent reply other threads:[~2016-11-05 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 3:55 [Buildroot] pseudo: fix build for python3 based distros Gaël PORTAY
2016-11-05 3:55 ` [Buildroot] [PATCH] " Gaël PORTAY
2016-11-05 12:39 ` Yann E. MORIN
2016-11-05 13:47 ` Gaël PORTAY
2016-11-05 12:43 ` Thomas Petazzoni
2016-11-05 13:43 ` Gaël PORTAY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161105134352.GA26483@archlinux \
--to=gael.portay@savoirfairelinux.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox