Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG
@ 2016-11-06 20:05 stefan.nickl at gmail.com
  2016-11-06 20:37 ` Samuel Martin
  2016-11-06 21:31 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: stefan.nickl at gmail.com @ 2016-11-06 20:05 UTC (permalink / raw)
  To: buildroot

From: Stefan Nickl <Stefan.Nickl@gmail.com>

Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

---
Seems like a typo, see assert(3) for the correct spelling.

diff --git a/support/misc/toolchainfile.cmake.in b/support/misc/toolchainfile.cmake.in
index e095356..d4252dd 100644
--- a/support/misc/toolchainfile.cmake.in
+++ b/support/misc/toolchainfile.cmake.in
@@ -25,8 +25,8 @@ set(CMAKE_SYSTEM_PROCESSOR @@CMAKE_SYSTEM_PROCESSOR@@)
 #   screwed up and there is nothing Buildroot can do about that :(
 set(CMAKE_C_FLAGS_DEBUG "" CACHE STRING "Debug CFLAGS")
 set(CMAKE_CXX_FLAGS_DEBUG "" CACHE STRING "Debug CXXFLAGS")
-set(CMAKE_C_FLAGS_RELEASE " -DNEBUG" CACHE STRING "Release CFLAGS")
-set(CMAKE_CXX_FLAGS_RELEASE " -DNEBUG" CACHE STRING "Release CXXFLAGS")
+set(CMAKE_C_FLAGS_RELEASE " -DNDEBUG" CACHE STRING "Release CFLAGS")
+set(CMAKE_CXX_FLAGS_RELEASE " -DNDEBUG" CACHE STRING "Release CXXFLAGS")
 
 # Build type from the Buildroot configuration
 set(CMAKE_BUILD_TYPE @@CMAKE_BUILD_TYPE@@ CACHE STRING "Buildroot build configuration")
@@ -36,7 +36,7 @@ set(CMAKE_BUILD_TYPE @@CMAKE_BUILD_TYPE@@ CACHE STRING "Buildroot build configur
 # want to customize the compiler/linker flags, then:
 # * set them all on the cmake command line, e.g.:
 #     cmake -DCMAKE_C_FLAGS="@@TARGET_CFLAGS@@ -Dsome_custom_flag" ...
-# * and make sure the project's CMake code extendsthem like this if needed:
+# * and make sure the project's CMake code extends them like this if needed:
 #     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Dsome_definitions")
 set(CMAKE_C_FLAGS "@@TARGET_CFLAGS@@" CACHE STRING "Buildroot CFLAGS")
 set(CMAKE_CXX_FLAGS "@@TARGET_CXXFLAGS@@" CACHE STRING "Buildroot CXXFLAGS")
@@ -58,7 +58,7 @@ set(CMAKE_C_COMPILER "${RELOCATED_HOST_DIR}/@@TARGET_CC@@")
 set(CMAKE_CXX_COMPILER "${RELOCATED_HOST_DIR}/@@TARGET_CXX@@")
 if(@@TOOLCHAIN_HAS_FORTRAN@@)
   set(CMAKE_Fortran_FLAGS_DEBUG "" CACHE STRING "Debug Fortran FLAGS")
-  set(CMAKE_Fortran_FLAGS_RELEASE " -DNEBUG" CACHE STRING "Release Fortran FLAGS")
+  set(CMAKE_Fortran_FLAGS_RELEASE " -DNDEBUG" CACHE STRING "Release Fortran FLAGS")
   set(CMAKE_Fortran_FLAGS "@@TARGET_FCFLAGS@@" CACHE STRING "Buildroot FCFLAGS")
   set(CMAKE_Fortran_COMPILER "${RELOCATED_HOST_DIR}/@@TARGET_FC@@")
 endif()
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG
  2016-11-06 20:05 [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG stefan.nickl at gmail.com
@ 2016-11-06 20:37 ` Samuel Martin
  2016-11-06 21:31 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Samuel Martin @ 2016-11-06 20:37 UTC (permalink / raw)
  To: buildroot

On Sun, Nov 6, 2016 at 9:05 PM,  <stefan.nickl@gmail.com> wrote:
> From: Stefan Nickl <Stefan.Nickl@gmail.com>
>
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Acked-by: Samuel Martin <s.martin49@gmail.com>

Regards,

-- 
Samuel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG
  2016-11-06 20:05 [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG stefan.nickl at gmail.com
  2016-11-06 20:37 ` Samuel Martin
@ 2016-11-06 21:31 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-11-06 21:31 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  6 Nov 2016 21:05:13 +0100, stefan.nickl at gmail.com wrote:
> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> ---
> Seems like a typo, see assert(3) for the correct spelling.

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-06 21:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-06 20:05 [Buildroot] [PATCH] pkg-cmake: Change -DNEBUG to -DNDEBUG stefan.nickl at gmail.com
2016-11-06 20:37 ` Samuel Martin
2016-11-06 21:31 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox