Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript
Date: Mon,  7 Nov 2016 17:54:00 +0100	[thread overview]
Message-ID: <20161107165400.28802-1-gary.bisson@boundarydevices.com> (raw)

It was previously hardcoded to use the 1st partition although the
bootpart variable was used to download kernel/dtb from any partition.

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
Hi,

Just realized our bootscript was harcoding the partition number.

It is not suitable for systems which need to boot from any partition. It is
especially useful when using a A/B update scheme which means you either boot
from part 1 or 2 depending on last update (testing swupdate right now,
nice project!).

Regards,
Gary
---
 board/boundarydevices/common/6x_bootscript.txt | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/board/boundarydevices/common/6x_bootscript.txt b/board/boundarydevices/common/6x_bootscript.txt
index e8a08aa..2fc687a 100644
--- a/board/boundarydevices/common/6x_bootscript.txt
+++ b/board/boundarydevices/common/6x_bootscript.txt
@@ -92,14 +92,12 @@ fi
 
 setenv bootargs "${bootargs} console=${console},115200 vmalloc=400M consoleblank=0 rootwait fixrtc"
 
-bpart=1
-
 if test "sata" = "${dtype}" ; then
-	setenv bootargs "${bootargs} root=/dev/sda${bpart}" ;
+	setenv bootargs "${bootargs} root=/dev/sda${bootpart}" ;
 elif test "usb" = "${dtype}" ; then
-	setenv bootargs "${bootargs} root=/dev/sda${bpart}" ;
+	setenv bootargs "${bootargs} root=/dev/sda${bootpart}" ;
 else
-	setenv bootargs "${bootargs} root=/dev/mmcblk${disk}p${bpart}"
+	setenv bootargs "${bootargs} root=/dev/mmcblk${disk}p${bootpart}"
 fi
 
 if itest.s "x" != "x${disable_giga}" ; then
-- 
2.9.3

             reply	other threads:[~2016-11-07 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 16:54 Gary Bisson [this message]
2016-11-07 21:09 ` [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107165400.28802-1-gary.bisson@boundarydevices.com \
    --to=gary.bisson@boundarydevices.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox