Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript
@ 2016-11-07 16:54 Gary Bisson
  2016-11-07 21:09 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Gary Bisson @ 2016-11-07 16:54 UTC (permalink / raw)
  To: buildroot

It was previously hardcoded to use the 1st partition although the
bootpart variable was used to download kernel/dtb from any partition.

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
Hi,

Just realized our bootscript was harcoding the partition number.

It is not suitable for systems which need to boot from any partition. It is
especially useful when using a A/B update scheme which means you either boot
from part 1 or 2 depending on last update (testing swupdate right now,
nice project!).

Regards,
Gary
---
 board/boundarydevices/common/6x_bootscript.txt | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/board/boundarydevices/common/6x_bootscript.txt b/board/boundarydevices/common/6x_bootscript.txt
index e8a08aa..2fc687a 100644
--- a/board/boundarydevices/common/6x_bootscript.txt
+++ b/board/boundarydevices/common/6x_bootscript.txt
@@ -92,14 +92,12 @@ fi
 
 setenv bootargs "${bootargs} console=${console},115200 vmalloc=400M consoleblank=0 rootwait fixrtc"
 
-bpart=1
-
 if test "sata" = "${dtype}" ; then
-	setenv bootargs "${bootargs} root=/dev/sda${bpart}" ;
+	setenv bootargs "${bootargs} root=/dev/sda${bootpart}" ;
 elif test "usb" = "${dtype}" ; then
-	setenv bootargs "${bootargs} root=/dev/sda${bpart}" ;
+	setenv bootargs "${bootargs} root=/dev/sda${bootpart}" ;
 else
-	setenv bootargs "${bootargs} root=/dev/mmcblk${disk}p${bpart}"
+	setenv bootargs "${bootargs} root=/dev/mmcblk${disk}p${bootpart}"
 fi
 
 if itest.s "x" != "x${disable_giga}" ; then
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript
  2016-11-07 16:54 [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript Gary Bisson
@ 2016-11-07 21:09 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-11-07 21:09 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  7 Nov 2016 17:54:00 +0100, Gary Bisson wrote:
> It was previously hardcoded to use the 1st partition although the
> bootpart variable was used to download kernel/dtb from any partition.
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> Hi,

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-07 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 16:54 [Buildroot] [PATCH] board/boundarydevices: fix boot partition number in bootscript Gary Bisson
2016-11-07 21:09 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox