Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] htop: enable unicode if possible
Date: Wed, 9 Nov 2016 21:41:20 +0100	[thread overview]
Message-ID: <20161109214120.49af0145@free-electrons.com> (raw)
In-Reply-To: <20161109092739.4595-1-jezz@sysmic.org>

Hello,

On Wed,  9 Nov 2016 10:27:39 +0100, J?r?me Pouiller wrote:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/htop/htop.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/htop/htop.mk b/package/htop/htop.mk
> index 7409a78..e1a658b 100644
> --- a/package/htop/htop.mk
> +++ b/package/htop/htop.mk
> @@ -7,7 +7,9 @@
>  HTOP_VERSION = 2.0.2
>  HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
>  HTOP_DEPENDENCIES = ncurses
> +ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
>  HTOP_CONF_OPTS = --disable-unicode
> +endif

We want something more explicit, like:

ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
HTOP_CONF_OPTS += --enable-unicode
else
HTOP_CONF_OPTS += --disable-unicode
endif

Could you try this, in both situations, and see if it works as expected?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-11-09 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  9:27 [Buildroot] [PATCH] htop: enable unicode if possible Jérôme Pouiller
2016-11-09 20:41 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109214120.49af0145@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox