Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] htop: enable unicode if possible
@ 2016-11-09  9:27 Jérôme Pouiller
  2016-11-09 20:41 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Jérôme Pouiller @ 2016-11-09  9:27 UTC (permalink / raw)
  To: buildroot

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/htop/htop.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/htop/htop.mk b/package/htop/htop.mk
index 7409a78..e1a658b 100644
--- a/package/htop/htop.mk
+++ b/package/htop/htop.mk
@@ -7,7 +7,9 @@
 HTOP_VERSION = 2.0.2
 HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
 HTOP_DEPENDENCIES = ncurses
+ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
 HTOP_CONF_OPTS = --disable-unicode
+endif
 # Prevent htop build system from searching the host paths
 HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/ncurses5-config
 HTOP_LICENSE = GPLv2
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] htop: enable unicode if possible
  2016-11-09  9:27 [Buildroot] [PATCH] htop: enable unicode if possible Jérôme Pouiller
@ 2016-11-09 20:41 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-11-09 20:41 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  9 Nov 2016 10:27:39 +0100, J?r?me Pouiller wrote:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/htop/htop.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/htop/htop.mk b/package/htop/htop.mk
> index 7409a78..e1a658b 100644
> --- a/package/htop/htop.mk
> +++ b/package/htop/htop.mk
> @@ -7,7 +7,9 @@
>  HTOP_VERSION = 2.0.2
>  HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
>  HTOP_DEPENDENCIES = ncurses
> +ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
>  HTOP_CONF_OPTS = --disable-unicode
> +endif

We want something more explicit, like:

ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
HTOP_CONF_OPTS += --enable-unicode
else
HTOP_CONF_OPTS += --disable-unicode
endif

Could you try this, in both situations, and see if it works as expected?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-09 20:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-09  9:27 [Buildroot] [PATCH] htop: enable unicode if possible Jérôme Pouiller
2016-11-09 20:41 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox