From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7] kodi: allow enablement of libamcodec as codec if selected
Date: Wed, 9 Nov 2016 22:49:30 +0100 [thread overview]
Message-ID: <20161109224930.4ae4ee9e@free-electrons.com> (raw)
In-Reply-To: <20161109190733.11189-1-daggs@gmx.com>
Hello,
On Wed, 9 Nov 2016 21:07:33 +0200, Dagg Stompler wrote:
> allow usage of amcodec if kodi is built and libamcodec is selected
>
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
I've applied to next, but it would be really really good if you could
review your own patches before sending them. There was an obvious big
mistake in your patch, see below.
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index e0361da..f9d1a11 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -96,9 +96,9 @@ endif
> ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> KODI_DEPENDENCIES += rpi-userland
> KODI_CONF_OPTS += --with-platform=raspberry-pi --enable-player=omxplayer
> -KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> - -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
> - LIBS="-lvcos -lvchostif"
> +-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> +-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux
How do you expect those two lines to work? You don't even tell make
that this value should be assigned to the KODI_INCLUDES variable.
Clearly you didn't review your patch carefully enough here.
> +KODI_LIBS="-lvcos -lvchostif"
Space before/after the = sign, and double quotes not needed.
> +KODI_CONF_ENV += \
> +INCLUDES="$(KODI_INCLUDES)" \
> +LIBS="$(KODI_LIBS)"
The values should have been indented with on tab.
Applied with those issues fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-09 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:07 [Buildroot] [PATCH v7] kodi: allow enablement of libamcodec as codec if selected Dagg Stompler
2016-11-09 21:49 ` Thomas Petazzoni [this message]
2016-11-13 7:45 ` daggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109224930.4ae4ee9e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox