From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Enable option of nodeJS 4.1.2 in buildroot 2015.11
Date: Sat, 12 Nov 2016 22:01:40 +0100 [thread overview]
Message-ID: <20161112210140.GA3700@free.fr> (raw)
In-Reply-To: <20161111150017.29e032b5@free-electrons.com>
Thomas, All,
On 2016-11-11 15:00 +0100, Thomas Petazzoni spake thusly:
> On Fri, 11 Nov 2016 06:37:06 +0200, Baruch Siach wrote:
>
> > That's because nodejs 4.1.2 on Buildroot 2015.11 (and 6.7.0 on current master)
> > depends on BR2_ARM_CPU_HAS_VFPV2:
> >
> > config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> > bool
> > # On supported architectures other than ARM, no special requirement
> > default y if !BR2_arm
> > # On ARM, at least ARMv6+ with VFPv2+ is needed
> > default y if !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
> >
> > The comment seems indicates that BR2_ARM_CPU_HAS_VFPV3 should also be fine.
> > You may try changing this line to
> >
> > default y if !BR2_ARM_CPU_ARMV5 && (BR2_ARM_CPU_HAS_VFPV2 || BR2_ARM_CPU_HAS_VFPV3)
> >
> > Yann, you added this dependency in commit f443386c5d. Is that the right fix?
Not really: if VFPv3 is enabled, so is VFPv2, see the conditions:
https://git.buildroot.org/buildroot/tree/arch/Config.in.arm#n21
and see the reasons below...
> I'm wondering if BR2_ARM_CPU_HAS_VFPV3 shouldn't select
> BR2_ARM_CPU_HAS_VFPV2, and ditto for V4 selecting V3.
Unless I'm mistaken, that's already the case, and has been so at least
since 2013:
5f959a1c arch: improve ARM floating point support and add support for EABIhf
21 config BR2_ARM_CPU_HAS_VFPV3
22 bool
23 select BR2_ARM_CPU_HAS_VFPV2
[--SNIP--]
30 config BR2_ARM_CPU_HAS_VFPV4
31 bool
32 select BR2_ARM_CPU_HAS_VFPV3
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-11-12 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 1:28 [Buildroot] Enable option of nodeJS 4.1.2 in buildroot 2015.11 Lijun QIN
2016-11-11 4:37 ` Baruch Siach
2016-11-11 13:41 ` [Buildroot] Fwd: " Lijun QIN
2016-11-12 21:08 ` Yann E. MORIN
2016-11-11 14:00 ` [Buildroot] " Thomas Petazzoni
2016-11-12 21:01 ` Yann E. MORIN [this message]
2016-11-13 8:53 ` Thomas Petazzoni
2016-11-13 9:00 ` Yann E. MORIN
2016-11-13 11:11 ` Thomas Petazzoni
2016-11-14 2:10 ` Lijun QIN
2016-11-13 9:12 ` Baruch Siach
2016-11-12 21:13 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112210140.GA3700@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox