Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Enable option of nodeJS 4.1.2 in buildroot 2015.11
Date: Sun, 13 Nov 2016 10:00:39 +0100	[thread overview]
Message-ID: <20161113090038.GA3580@free.fr> (raw)
In-Reply-To: <20161113095304.3dcd95f6@free-electrons.com>

Thomas, All,

On 2016-11-13 09:53 +0100, Thomas Petazzoni spake thusly:
> On Sat, 12 Nov 2016 22:01:40 +0100, Yann E. MORIN wrote:
[--SNIP--]
> > > I'm wondering if BR2_ARM_CPU_HAS_VFPV3 shouldn't select
> > > BR2_ARM_CPU_HAS_VFPV2, and ditto for V4 selecting V3.  
> > 
> > Unless I'm mistaken, that's already the case, and has been so at least
> > since 2013:
> > 
> >     5f959a1c arch: improve ARM floating point support and add support for EABIhf
> > 
> >    21 config BR2_ARM_CPU_HAS_VFPV3
> >    22 	bool
> >    23 	select BR2_ARM_CPU_HAS_VFPV2
> >    [--SNIP--]
> >    30 config BR2_ARM_CPU_HAS_VFPV4
> >    31 	bool
> >    32 	 select BR2_ARM_CPU_HAS_VFPV3
> 
> I don't see how I could miss this. But then, why did Lijun had issues
> selecting NodeJS, and Baruch proposal to add || BR2_ARM_CPU_HAS_VFPV3
> solved it?

It did _not_ solve the issue, because Lijun did not have BR2_ARM_ENABLE_VFP
enabled, which meant he also did not have BR2_ARM_CPU_HAS_VFPV3 enabled.

Instead, he did use BR2_ARM_CPU_MAYBE_HAS_VFPV3 which is wrong.

Lijun must enable BR2_ARM_ENABLE_VFP in his config, if his CPU (cortex-a9)
indeed has a VFP. If not, then he'll be stuck with nodejs 0.10.x and
there is nothing we can do about that.

Nothing to investigate here on our side. 

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-11-13  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11  1:28 [Buildroot] Enable option of nodeJS 4.1.2 in buildroot 2015.11 Lijun QIN
2016-11-11  4:37 ` Baruch Siach
2016-11-11 13:41   ` [Buildroot] Fwd: " Lijun QIN
2016-11-12 21:08     ` Yann E. MORIN
2016-11-11 14:00   ` [Buildroot] " Thomas Petazzoni
2016-11-12 21:01     ` Yann E. MORIN
2016-11-13  8:53       ` Thomas Petazzoni
2016-11-13  9:00         ` Yann E. MORIN [this message]
2016-11-13 11:11           ` Thomas Petazzoni
2016-11-14  2:10             ` Lijun QIN
2016-11-13  9:12         ` Baruch Siach
2016-11-12 21:13 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161113090038.GA3580@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox