Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] xapp_xload: fix musl build
@ 2016-11-20 22:28 Arnout Vandecappelle
  2016-11-21 20:22 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2016-11-20 22:28 UTC (permalink / raw)
  To: buildroot

xapp_xload tries to include protocols/rwhod.h, which isn't available on
musl. Fortunately, the package also has stub code that can be enabled
with -DRLOADSTUB (this is done e.g. on Cygwin).

This should probably be detected in configure, but that's a lot more
work.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/x11r7/xapp_xload/xapp_xload.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/x11r7/xapp_xload/xapp_xload.mk b/package/x11r7/xapp_xload/xapp_xload.mk
index 1db0db5..364d247 100644
--- a/package/x11r7/xapp_xload/xapp_xload.mk
+++ b/package/x11r7/xapp_xload/xapp_xload.mk
@@ -11,4 +11,9 @@ XAPP_XLOAD_LICENSE = MIT
 XAPP_XLOAD_LICENSE_FILES = COPYING
 XAPP_XLOAD_DEPENDENCIES = xlib_libXaw
 
+ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
+# musl doesn't have rwhod.h, but xload can replace it with stubs
+XAPP_XLOAD_CONF_OPTS += CFLAGS="$(TARGET_CFLAGS) -DRLOADSTUB"
+endif
+
 $(eval $(autotools-package))
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] xapp_xload: fix musl build
  2016-11-20 22:28 [Buildroot] [PATCH] xapp_xload: fix musl build Arnout Vandecappelle
@ 2016-11-21 20:22 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-11-21 20:22 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 20 Nov 2016 23:28:58 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> xapp_xload tries to include protocols/rwhod.h, which isn't available on
> musl. Fortunately, the package also has stub code that can be enabled
> with -DRLOADSTUB (this is done e.g. on Cygwin).
> 
> This should probably be detected in configure, but that's a lot more
> work.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/x11r7/xapp_xload/xapp_xload.mk | 5 +++++
>  1 file changed, 5 insertions(+)

You forgot a reference to the autobuilder failure, and I forgot as well
before pushing :/

Applied to master anyway, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-21 20:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-20 22:28 [Buildroot] [PATCH] xapp_xload: fix musl build Arnout Vandecappelle
2016-11-21 20:22 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox