From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3
Date: Thu, 24 Nov 2016 09:01:08 +0100 [thread overview]
Message-ID: <20161124090108.4662368c@free-electrons.com> (raw)
In-Reply-To: <31d9d115-a051-8c3d-efae-6225423ba481@mind.be>
Hello,
On Thu, 24 Nov 2016 00:38:33 +0100, Arnout Vandecappelle wrote:
> On 23-11-16 23:21, Thomas Petazzoni wrote:
> [snip]
> >> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> >> index 3991bc1..72e7292 100644
> >> --- a/toolchain/helpers.mk
> >> +++ b/toolchain/helpers.mk
> >> @@ -145,8 +145,7 @@ check_kernel_headers_version = \
> >> check_gcc_version = \
> >> expected_version="$(strip $2)" ; \
> >> if [ -z "$${expected_version}" ]; then \
> >> - printf "Internal error, gcc version unknown (no GCC_AT_LEAST_X_Y selected)\n"; \
> >> - exit 1 ; \
> >> + exit 0 ; \
> >
> > Why?
>
> As stated in the commit log:
>
> When [BR2_TOOLCHAIN_GCC_AT_LEAST] is
> empty, we don't do a version check at all in check_gcc_version.
>
> Perhaps I should add to that "(previously we errored out)".
Well, we're still erroring out, but with a 0 exit code. So I must be
missing something.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-24 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 11:14 [Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3 Arnout Vandecappelle
2016-11-23 12:22 ` Thomas Petazzoni
2016-11-23 12:27 ` Arnout Vandecappelle
2016-11-23 22:19 ` Thomas Petazzoni
2016-11-23 23:36 ` Arnout Vandecappelle
2016-11-23 22:21 ` Thomas Petazzoni
2016-11-23 23:38 ` Arnout Vandecappelle
2016-11-24 8:01 ` Thomas Petazzoni [this message]
2016-11-24 8:39 ` Arnout Vandecappelle
2016-11-24 8:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124090108.4662368c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox