Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] preparing for release
       [not found] <20161130053136.GU14207@waldemar-brodkorb.de>
@ 2016-11-30  5:43 ` Vineet Gupta
  2016-11-30 17:02   ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Vineet Gupta @ 2016-11-30  5:43 UTC (permalink / raw)
  To: buildroot

+CC Thomas for buildroot aspect

On 11/29/2016 09:31 PM, Waldemar Brodkorb wrote:
> Hi,
>
> I am preparing a release and would like to remove UCLIBC_HAS_LFS
> before doing it.
>
> I believe UCLIBC_HAS_LFS does make the code more complex and
> the benefit to disable it to save some bytes is not high enough.
>
> Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
>
> Attached is a patch.
>
> Any comments?
>
> best regards
>  Waldemar

I welcome this change - is there going to be impact on downstream projects like
busybox. What if it some disables CONFIG_LFS inside busybox ?

-Vineet

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Buildroot] preparing for release
  2016-11-30  5:43 ` [Buildroot] preparing for release Vineet Gupta
@ 2016-11-30 17:02   ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-11-30 17:02 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 29 Nov 2016 21:43:20 -0800, Vineet Gupta wrote:

> On 11/29/2016 09:31 PM, Waldemar Brodkorb wrote:
> > Hi,
> >
> > I am preparing a release and would like to remove UCLIBC_HAS_LFS
> > before doing it.
> >
> > I believe UCLIBC_HAS_LFS does make the code more complex and
> > the benefit to disable it to save some bytes is not high enough.
> >
> > Most users have UCLIBC_HAS_LFS enabled and it is enabled by default.
> >
> > Attached is a patch.
> >
> > Any comments?
> >
> > best regards
> >  Waldemar  
> 
> I welcome this change - is there going to be impact on downstream projects like
> busybox. What if it some disables CONFIG_LFS inside busybox ?

In Buildroot, we have dropped the ability to disable LFS since March
2015. It was really too annoying to maintain the !LFS case, for no real
benefit.

So I'm completely fine with uClibc-ng dropping !LFS support upstream,
since Buildroot no longer cares about this possibility.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-30 17:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20161130053136.GU14207@waldemar-brodkorb.de>
2016-11-30  5:43 ` [Buildroot] preparing for release Vineet Gupta
2016-11-30 17:02   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox