From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bluez5_utils: add autoreconf back
Date: Mon, 5 Dec 2016 22:19:22 +0100 [thread overview]
Message-ID: <20161205221922.13838a32@free-electrons.com> (raw)
In-Reply-To: <d6c03c59-32b7-3749-80a7-ba4c812b3f87@mind.be>
Hello,
On Mon, 5 Dec 2016 22:16:03 +0100, Arnout Vandecappelle wrote:
> > Have you tried adding BLUEZ5_AUTORECONF = YES to your external.mk file?
>
> That won't work, because it's used in an ifeq in the autotools-package
> expansion, and external.mk is included after the packages.
Gah.
> It does work if you put it in override.mk, but that's not convenient in an
> external.
I guess you wanted to say "local.mk" and not "override.mk", right?
But in any case, I don't think we want to have a <pkg>_AUTORECONF = YES
in a package "just in case" someone has patches against this package in
his external tree. Otherwise, all autoconf packages should be
<pkg>_AUTORECONF = YES.
So, we've got two options here:
1. Say that having to change the original .mk file of a package in
Buildroot is a fact of life if you add custom patches for this
package.
2. Imagine a mechanism that allows the "external" stuff to set
autoreconf on a per-package basis.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-05 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 13:15 [Buildroot] [PATCH] bluez5_utils: add autoreconf back Gary Bisson
2016-12-05 20:32 ` Thomas Petazzoni
2016-12-05 21:16 ` Arnout Vandecappelle
2016-12-05 21:19 ` Thomas Petazzoni [this message]
2016-12-05 22:00 ` Arnout Vandecappelle
2016-12-05 22:39 ` Peter Korsgaard
2016-12-05 22:52 ` Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205221922.13838a32@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox