Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bluez5_utils: add autoreconf back
Date: Mon, 05 Dec 2016 23:39:21 +0100	[thread overview]
Message-ID: <87eg1m57c6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <d545c88d-8eae-ed7a-23ab-781924c58571@mind.be> (Arnout Vandecappelle's message of "Mon, 5 Dec 2016 23:00:39 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> So, we've got two options here:
 >> 
 >> 1. Say that having to change the original .mk file of a package in
 >> Buildroot is a fact of life if you add custom patches for this
 >> package.

 >  Actually, for this particular case, it would be sufficient to patch Makefile in
 > addition to Makefile.in. Which is a fact of life I'd say. We also sometimes have
 > to do that when autoreconf doesn't work.

 >> 2. Imagine a mechanism that allows the "external" stuff to set
 >> autoreconf on a per-package basis.

 >  Eek please no.

 >  One thing I can imagine is that the expansion of the package infras is done
 > later (after inclusion of external.mk). The first pass would just set variables,
 > not define rules and definitely not use any ifdefs. The rules etc. would then
 > have to avoid using $(1) $(2) etc, and just rely on $($(PKG)_NAME) and friends.

Lets not complicate things too much. Just patching Makefile as well
and/or modifying the package is imho good enough.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-12-05 22:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 13:15 [Buildroot] [PATCH] bluez5_utils: add autoreconf back Gary Bisson
2016-12-05 20:32 ` Thomas Petazzoni
2016-12-05 21:16   ` Arnout Vandecappelle
2016-12-05 21:19     ` Thomas Petazzoni
2016-12-05 22:00       ` Arnout Vandecappelle
2016-12-05 22:39         ` Peter Korsgaard [this message]
2016-12-05 22:52           ` Gary Bisson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eg1m57c6.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox