Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] arch/Config.in.arm: add Cortex-A57 and Cortex-A72
@ 2016-12-05 22:07 Thomas Petazzoni
  2016-12-06 13:20 ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2016-12-05 22:07 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=2131f1b3817d594ce24ac9ba263f104077cf7c49
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Add two popular ARM64 cores to the list of supported cores: Cortex-A57
and Cortex-A72.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/Config.in.arm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index 592b097..743f6ca 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -198,6 +198,20 @@ config BR2_cortex_a53
 	select BR2_ARM_CPU_HAS_FP_ARMV8
 	select BR2_ARM_CPU_ARMV8
 	select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_cortex_a57
+	bool "cortex-A57"
+	select BR2_ARM_CPU_HAS_ARM
+	select BR2_ARM_CPU_HAS_NEON
+	select BR2_ARM_CPU_HAS_FP_ARMV8
+	select BR2_ARM_CPU_ARMV8
+	select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_cortex_a72
+	bool "cortex-A72"
+	select BR2_ARM_CPU_HAS_ARM
+	select BR2_ARM_CPU_HAS_NEON
+	select BR2_ARM_CPU_HAS_FP_ARMV8
+	select BR2_ARM_CPU_ARMV8
+	select BR2_ARCH_HAS_MMU_OPTIONAL
 config BR2_cortex_m3
 	bool "cortex-M3"
 	select BR2_ARM_CPU_HAS_THUMB2
@@ -520,6 +534,12 @@ config BR2_GCC_TARGET_CPU
 	default "cortex-a53"		if (BR2_cortex_a53 && !BR2_ARCH_IS_64)
 	default "cortex-a53+fp"		if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
 	default "cortex-a53+fp+simd" 	if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
+	default "cortex-a57"		if (BR2_cortex_a57 && !BR2_ARCH_IS_64)
+	default "cortex-a57+fp"		if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
+	default "cortex-a57+fp+simd" 	if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
+	default "cortex-a72"		if (BR2_cortex_a72 && !BR2_ARCH_IS_64)
+	default "cortex-a72+fp"		if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
+	default "cortex-a72+fp+simd" 	if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
 
 config BR2_GCC_TARGET_ABI
 	default "aapcs-linux"	if BR2_arm || BR2_armeb

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] arch/Config.in.arm: add Cortex-A57 and Cortex-A72
  2016-12-05 22:07 [Buildroot] [git commit] arch/Config.in.arm: add Cortex-A57 and Cortex-A72 Thomas Petazzoni
@ 2016-12-06 13:20 ` Peter Korsgaard
  2016-12-06 14:04   ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2016-12-06 13:20 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=2131f1b3817d594ce24ac9ba263f104077cf7c49
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Add two popular ARM64 cores to the list of supported cores: Cortex-A57
 > and Cortex-A72.

Hmm, do old toolchains know about these cores?

Looking around in gcc.git, it seems like they were added:

a53/a57 in 4.8 for aarch64 / 4.9 for arm
a72 in 5.1 for aarch64/arm

So we need to ensure the older gcc versions cannot be selected when
these variants are selected. We possibly also need to do something for
external toolchains.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] arch/Config.in.arm: add Cortex-A57 and Cortex-A72
  2016-12-06 13:20 ` Peter Korsgaard
@ 2016-12-06 14:04   ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-12-06 14:04 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 06 Dec 2016 14:20:29 +0100, Peter Korsgaard wrote:

>  > commit: https://git.buildroot.net/buildroot/commit/?id=2131f1b3817d594ce24ac9ba263f104077cf7c49
>  > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master  
> 
>  > Add two popular ARM64 cores to the list of supported cores: Cortex-A57
>  > and Cortex-A72.  
> 
> Hmm, do old toolchains know about these cores?
> 
> Looking around in gcc.git, it seems like they were added:
> 
> a53/a57 in 4.8 for aarch64 / 4.9 for arm
> a72 in 5.1 for aarch64/arm

Correct.

> So we need to ensure the older gcc versions cannot be selected when
> these variants are selected. We possibly also need to do something for
> external toolchains.

Indeed.

I won't have a look tonight, but can have a look tomorrow, unless
someone beats me at it.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-06 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-05 22:07 [Buildroot] [git commit] arch/Config.in.arm: add Cortex-A57 and Cortex-A72 Thomas Petazzoni
2016-12-06 13:20 ` Peter Korsgaard
2016-12-06 14:04   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox