* [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh
@ 2016-12-07 7:08 Waldemar Brodkorb
2016-12-07 8:22 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Waldemar Brodkorb @ 2016-12-07 7:08 UTC (permalink / raw)
To: buildroot
Fixes static linking of berkeleydb package, where ltmain.sh
is not in the sub-directory that contains configure.
Always search the complete source directory.
Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Waldema Brodkorb <wbx@openadk.org>
---
package/pkg-autotools.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index 00822e2..f7b8488 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -59,7 +59,7 @@ endef
#
define LIBTOOL_PATCH_HOOK
@$(call MESSAGE,"Patching libtool")
- $(Q)for i in `find $($(PKG)_SRCDIR) -name ltmain.sh`; do \
+ $(Q)for i in `find $($(PKG)_DIR) -name ltmain.sh`; do \
ltmain_version=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \
sed -e 's/\([0-9]*\.[0-9]*\).*/\1/' -e 's/\"//'`; \
ltmain_patchlevel=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh
2016-12-07 7:08 [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh Waldemar Brodkorb
@ 2016-12-07 8:22 ` Thomas Petazzoni
2016-12-07 8:27 ` Waldemar Brodkorb
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-12-07 8:22 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 7 Dec 2016 08:08:54 +0100, Waldemar Brodkorb wrote:
> Fixes static linking of berkeleydb package, where ltmain.sh
> is not in the sub-directory that contains configure.
> Always search the complete source directory.
>
> Fixes:
> http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
It should be your SoB here, since you appear as the author of this
patch, unless you "git format --amend --author=...".
> Tested-by: Waldema Brodkorb <wbx@openadk.org>
Your first name has changed? :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh
2016-12-07 8:22 ` Thomas Petazzoni
@ 2016-12-07 8:27 ` Waldemar Brodkorb
2016-12-07 8:34 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Waldemar Brodkorb @ 2016-12-07 8:27 UTC (permalink / raw)
To: buildroot
Hi,
Thomas Petazzoni wrote,
> Hello,
>
> On Wed, 7 Dec 2016 08:08:54 +0100, Waldemar Brodkorb wrote:
> > Fixes static linking of berkeleydb package, where ltmain.sh
> > is not in the sub-directory that contains configure.
> > Always search the complete source directory.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> It should be your SoB here, since you appear as the author of this
> patch, unless you "git format --amend --author=...".
So should I resend with my SoB and mention you in the log or
what is the correct way in this case, because the analysis was made
by me and the patch by you. I really don't care ;)
> > Tested-by: Waldema Brodkorb <wbx@openadk.org>
>
> Your first name has changed? :-)
I thought it might be good idea to have a shorter name ;)
Don't sent patches before first coffee ;)
best regards
Waldemar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh
2016-12-07 8:27 ` Waldemar Brodkorb
@ 2016-12-07 8:34 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-12-07 8:34 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 7 Dec 2016 09:27:43 +0100, Waldemar Brodkorb wrote:
> > On Wed, 7 Dec 2016 08:08:54 +0100, Waldemar Brodkorb wrote:
> > > Fixes static linking of berkeleydb package, where ltmain.sh
> > > is not in the sub-directory that contains configure.
> > > Always search the complete source directory.
> > >
> > > Fixes:
> > > http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
> > >
> > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >
> > It should be your SoB here, since you appear as the author of this
> > patch, unless you "git format --amend --author=...".
>
> So should I resend with my SoB and mention you in the log or
> what is the correct way in this case, because the analysis was made
> by me and the patch by you. I really don't care ;)
Actually, the change itself was proposed by Arnout, and I just tested
it quickly.
Just put you as the author, I really don't care for such a simple
change.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh
@ 2016-12-07 18:41 Waldemar Brodkorb
2016-12-07 19:04 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Waldemar Brodkorb @ 2016-12-07 18:41 UTC (permalink / raw)
To: buildroot
Fixes static linking of berkeleydb package, where ltmain.sh
is not in the sub-directory that contains configure.
Always search the complete source directory.
Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
Solution found after discussion and suggestions with Arnout and
Thomas P.
thx
---
package/pkg-autotools.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index 00822e2..f7b8488 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -59,7 +59,7 @@ endef
#
define LIBTOOL_PATCH_HOOK
@$(call MESSAGE,"Patching libtool")
- $(Q)for i in `find $($(PKG)_SRCDIR) -name ltmain.sh`; do \
+ $(Q)for i in `find $($(PKG)_DIR) -name ltmain.sh`; do \
ltmain_version=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \
sed -e 's/\([0-9]*\.[0-9]*\).*/\1/' -e 's/\"//'`; \
ltmain_patchlevel=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-07 19:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 7:08 [Buildroot] [PATCH] pkg-autotools: search in the source directory for ltmain.sh Waldemar Brodkorb
2016-12-07 8:22 ` Thomas Petazzoni
2016-12-07 8:27 ` Waldemar Brodkorb
2016-12-07 8:34 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2016-12-07 18:41 Waldemar Brodkorb
2016-12-07 19:04 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox