[Buildroot] [PATCH] package/enlightenment: remove uClibc (legacy) workaround

[Buildroot] [PATCH] package/enlightenment: remove uClibc (legacy) workaround

[Romain Naour]

Buildroot doesn't support uClibc (legacy) since 2016.02 release, so
this workaround is not needed anymore.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/enlightenment/enlightenment.mk | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
index 01448ee..7037afe 100644
--- a/package/enlightenment/enlightenment.mk
+++ b/package/enlightenment/enlightenment.mk
@@ -30,11 +30,6 @@ else
 ENLIGHTENMENT_CONF_OPTS += --disable-systemd
 endif
 
-# uClibc has an old incomplete sys/ptrace.h for powerpc & sparc
-ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
-ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
-endif
-
 # alsa backend needs mixer support
 ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
 ENLIGHTENMENT_DEPENDENCIES += alsa-lib
-- 
2.5.5

[Buildroot] [PATCH] package/enlightenment: remove uClibc (legacy) workaround

[Thomas Petazzoni]

Hello,

On Sat, 10 Dec 2016 16:50:46 +0100, Romain Naour wrote:
> Buildroot doesn't support uClibc (legacy) since 2016.02 release, so
> this workaround is not needed anymore.

BR2_TOOLCHAIN_USES_UCLIBC=y when uClibc-ng is used, I'm sure you now
that. Is this problem fixed in uClibc-ng? If so, it would be good to
mention that in the commit log, because right now, the wording of the
commit log is somewhat confusing in that regard.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] package/enlightenment: remove uClibc (legacy) workaround

[Romain Naour]

Hi Thomas,

Le 10/12/2016 ? 21:31, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Sat, 10 Dec 2016 16:50:46 +0100, Romain Naour wrote:
>> Buildroot doesn't support uClibc (legacy) since 2016.02 release, so
>> this workaround is not needed anymore.
> 
> BR2_TOOLCHAIN_USES_UCLIBC=y when uClibc-ng is used, I'm sure you now
> that. Is this problem fixed in uClibc-ng? If so, it would be good to
> mention that in the commit log, because right now, the wording of the
> commit log is somewhat confusing in that regard.

This workaround was added for uClibc <= 0.9.33.2 by commit [1].
This issue has been fixed long time ago in uClibc-ng for powerpc, sparc and
xtensa [2].

Nowadays, enlightenment can't be selected for xtensa ans sparc due to luajit
dependency from the efl stack. So this part of enlightenment.mk is outdated.

Also, I think that the alsa-lib dependency could be reworked since there is a
--enable/disable-mixer option for alsa E module.

Ok, let me improve the commit log with these explanations :)

Best regards,
Romain

[1]
https://git.buildroot.net/buildroot/commit/?id=37acd25ee1376de5734415ac60be16991ee6d150

[2]
https://git.buildroot.net/buildroot/commit/?id=0b056944f5878304f51af3e9edb6d596f24fc370

> 
> Thanks,
> 
> Thomas
>