Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] jpeg: fix typo introduced when fixing the indentation
@ 2016-12-11 17:36 Thomas Petazzoni
  2016-12-11 17:40 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2016-12-11 17:36 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=09d48dce0a75e93d560d129ca5f3883650ee63bf
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/jpeg/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/jpeg/Config.in b/package/jpeg/Config.in
index 2bcf405..8de45a3 100644
--- a/package/jpeg/Config.in
+++ b/package/jpeg/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_JPEG
 config BR2_PACKAGE_JPEG_SIMD_SUPPORT
        bool
        default y if BR2_X86_CPU_HAS_MMX || BR2_ARM_CPU_HAS_NEON || \
-		 BR2_POWERPC_CPU_HAS_ALTIVEC
+		 BR2_POWERPC_CPU_HAS_ALTIVEC || \
 		 BR2_aarch64 || BR2_aarch64_be
 
 if BR2_PACKAGE_JPEG

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] jpeg: fix typo introduced when fixing the indentation
  2016-12-11 17:36 [Buildroot] [git commit] jpeg: fix typo introduced when fixing the indentation Thomas Petazzoni
@ 2016-12-11 17:40 ` Yann E. MORIN
  2016-12-11 18:05   ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2016-12-11 17:40 UTC (permalink / raw)
  To: buildroot

Thomas, All,

On 2016-12-11 18:36 +0100, Thomas Petazzoni spake thusly:
> commit: https://git.buildroot.net/buildroot/commit/?id=09d48dce0a75e93d560d129ca5f3883650ee63bf
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/jpeg/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/jpeg/Config.in b/package/jpeg/Config.in
> index 2bcf405..8de45a3 100644
> --- a/package/jpeg/Config.in
> +++ b/package/jpeg/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_JPEG
>  config BR2_PACKAGE_JPEG_SIMD_SUPPORT
>         bool
>         default y if BR2_X86_CPU_HAS_MMX || BR2_ARM_CPU_HAS_NEON || \
> -		 BR2_POWERPC_CPU_HAS_ALTIVEC
> +		 BR2_POWERPC_CPU_HAS_ALTIVEC || \
>  		 BR2_aarch64 || BR2_aarch64_be

Alternatively, I think it is easier to read if it is written like that:

    config BR2_PACKAGE_JPEG_SIMD_SUPPORT
        bool
        default y if BR2_X86_CPU_HAS_MMX
        default y if BR2_ARM_CPU_HAS_NEON
        default y if BR2_POWERPC_CPU_HAS_ALTIVEC
        default y if BR2_aarch64 || BR2_aarch64_be

Regards,
Yann E. MORIN.

>  if BR2_PACKAGE_JPEG
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] jpeg: fix typo introduced when fixing the indentation
  2016-12-11 17:40 ` Yann E. MORIN
@ 2016-12-11 18:05   ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-12-11 18:05 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 11 Dec 2016 18:40:21 +0100, Yann E. MORIN wrote:

> Alternatively, I think it is easier to read if it is written like that:
> 
>     config BR2_PACKAGE_JPEG_SIMD_SUPPORT
>         bool
>         default y if BR2_X86_CPU_HAS_MMX
>         default y if BR2_ARM_CPU_HAS_NEON
>         default y if BR2_POWERPC_CPU_HAS_ALTIVEC
>         default y if BR2_aarch64 || BR2_aarch64_be

Agreed, this notation is a bit more readable.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-11 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-11 17:36 [Buildroot] [git commit] jpeg: fix typo introduced when fixing the indentation Thomas Petazzoni
2016-12-11 17:40 ` Yann E. MORIN
2016-12-11 18:05   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox