Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] lxc: enable lua if package is selected
@ 2016-12-17 23:09 Fabrice Fontaine
  2016-12-18  9:56 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2016-12-17 23:09 UTC (permalink / raw)
  To: buildroot

lua and python bindings were removed with the same patch:
https://patchwork.ozlabs.org/patch/367361. There is a real issue with
python but not with lua so enable it if lua is selected

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
---
 package/lxc/lxc.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index 589930f..980f1dc 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -10,7 +10,7 @@ LXC_LICENSE = LGPLv2.1+
 LXC_LICENSE_FILES = COPYING
 LXC_DEPENDENCIES = libcap host-pkgconf
 LXC_CONF_OPTS = --disable-apparmor --with-distro=buildroot \
-	--disable-lua --disable-python --disable-werror \
+	--disable-python --disable-werror \
 	$(if $(BR2_PACKAGE_BASH),,--disable-bash)
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
@@ -20,4 +20,11 @@ else
 LXC_CONF_OPTS += --disable-seccomp
 endif
 
+ifeq ($(BR2_PACKAGE_LUA),y)
+LXC_CONF_OPTS += --enable-lua
+LXC_DEPENDENCIES += lua
+else
+LXC_CONF_OPTS += --disable-lua
+endif
+
 $(eval $(autotools-package))
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] lxc: enable lua if package is selected
  2016-12-17 23:09 [Buildroot] [PATCH 1/1] lxc: enable lua if package is selected Fabrice Fontaine
@ 2016-12-18  9:56 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-12-18  9:56 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 18 Dec 2016 00:09:49 +0100, Fabrice Fontaine wrote:

> +ifeq ($(BR2_PACKAGE_LUA),y)
> +LXC_CONF_OPTS += --enable-lua
> +LXC_DEPENDENCIES += lua
> +else
> +LXC_CONF_OPTS += --disable-lua
> +endif

Does it work only with classic Lua, or also with LuaJIT? If it works
with LuaJIT, then we should do:

ifeq ($(BR2_PACKAGE_HAS_LUA_INTERPRETER),y)
LXC_CONF_OPTS += --enable-lua
LXC_DEPENDENCIES += luainterpreter
else
LXC_CONF_OPTS += --disable-lua
endif

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-18  9:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-17 23:09 [Buildroot] [PATCH 1/1] lxc: enable lua if package is selected Fabrice Fontaine
2016-12-18  9:56 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox