[Buildroot] [PATCH 1/1] lxc: add dependency on gnutls

[Buildroot] [PATCH 1/1] lxc: add dependency on gnutls

[Fabrice Fontaine]

lxc can use gnutls for various checksumming so add a dependency on it if
package is selected (there is no --enable-gnutls in configure)

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
---
 package/lxc/lxc.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index 2d04919..b910612 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -14,6 +14,10 @@ LXC_CONF_OPTS = --disable-apparmor --with-distro=buildroot \
 	--disable-python --disable-werror \
 	$(if $(BR2_PACKAGE_BASH),,--disable-bash)
 
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LXC_DEPENDENCIES += gnutls
+endif
+
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
 LXC_CONF_OPTS += --enable-seccomp
 LXC_DEPENDENCIES += libseccomp
-- 
2.5.0

[Buildroot] [PATCH 1/1] lxc: add dependency on gnutls

[Thomas Petazzoni]

Hello,

On Sun, 18 Dec 2016 12:56:25 +0100, Fabrice Fontaine wrote:
> lxc can use gnutls for various checksumming so add a dependency on it if
> package is selected (there is no --enable-gnutls in configure)
> 
> Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>

I was about to apply this... but in fact I don't see how lxc can use
gnutls. The configure script indeed has:

AC_CHECK_LIB([gnutls], [gnutls_hash_fast], [enable_gnutls=yes], [enable_gnutls=no])

But ${enable_gnutls} is only used to print a message. In the source
code, the gnutls related code is surrounded by HAVE_LIBGNUTLS
conditions, but this is never defined anywhere.

Bottom line, I don't see where gnutls is currently used in lxc in practice.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] lxc: add dependency on gnutls

[Fabrice Fontaine]

Hello,

2016-12-18 14:22 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-
electrons.com>:

> Hello,
>
> On Sun, 18 Dec 2016 12:56:25 +0100, Fabrice Fontaine wrote:
> > lxc can use gnutls for various checksumming so add a dependency on it if
> > package is selected (there is no --enable-gnutls in configure)
> >
> > Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
>
> I was about to apply this... but in fact I don't see how lxc can use
> gnutls. The configure script indeed has:
>
> AC_CHECK_LIB([gnutls], [gnutls_hash_fast], [enable_gnutls=yes],
> [enable_gnutls=no])
>
> But ${enable_gnutls} is only used to print a message. In the source
> code, the gnutls related code is surrounded by HAVE_LIBGNUTLS
> conditions, but this is never defined anywhere.
>
My bad, you're completely right ... I will ask the status of gnutls to lxc
project.

>
> Bottom line, I don't see where gnutls is currently used in lxc in practice.
>
> Best regards,
>
> Thomas Petazzoni
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20161218/e549d1c9/attachment.html>

[Buildroot] [PATCH 1/1] lxc: add dependency on gnutls

[Fabrice Fontaine]

Hello,

2016-12-18 15:17 GMT+01:00 Fabrice Fontaine <fontaine.fabrice@gmail.com>:

> Hello,
>
> 2016-12-18 14:22 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-electro
> ns.com>:
>
>> Hello,
>>
>> On Sun, 18 Dec 2016 12:56:25 +0100, Fabrice Fontaine wrote:
>> > lxc can use gnutls for various checksumming so add a dependency on it if
>> > package is selected (there is no --enable-gnutls in configure)
>> >
>> > Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
>>
>> I was about to apply this... but in fact I don't see how lxc can use
>> gnutls. The configure script indeed has:
>>
>> AC_CHECK_LIB([gnutls], [gnutls_hash_fast], [enable_gnutls=yes],
>> [enable_gnutls=no])
>>
>> But ${enable_gnutls} is only used to print a message. In the source
>> code, the gnutls related code is surrounded by HAVE_LIBGNUTLS
>> conditions, but this is never defined anywhere.
>>
> My bad, you're completely right ... I will ask the status of gnutls to lxc
> project.
>
There was a real issue: https://github.com/lxc/lxc/issues/1359 so I sent a
patch that was accepted. I also sent a v2 version of the buildroot patch.

>
>> Bottom line, I don't see where gnutls is currently used in lxc in
>> practice.
>>
>> Best regards,
>>
>> Thomas Petazzoni
>> --
>> Thomas Petazzoni, CTO, Free Electrons
>> Embedded Linux and Kernel engineering
>> http://free-electrons.com
>>
>
> Fabrice
>

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20161219/d6c2b962/attachment.html>