* [Buildroot] [PATCH] DEVELOPERS: Add entry for upower @ 2017-01-08 22:20 Romain Naour 2017-01-08 22:20 ` [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 Romain Naour 2017-01-09 8:43 ` [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Peter Korsgaard 0 siblings, 2 replies; 9+ messages in thread From: Romain Naour @ 2017-01-08 22:20 UTC (permalink / raw) To: buildroot Signed-off-by: Romain Naour <romain.naour@gmail.com> --- DEVELOPERS | 1 + 1 file changed, 1 insertion(+) diff --git a/DEVELOPERS b/DEVELOPERS index b4b460f..79dd097 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1275,6 +1275,7 @@ F: package/mcelog/ F: package/openpowerlink/ F: package/stress-ng/ F: package/terminology/ +F: package/upower/ F: package/xenomai/ N: Romain Perier <romain.perier@free-electrons.com> -- 2.9.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-08 22:20 [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Romain Naour @ 2017-01-08 22:20 ` Romain Naour 2017-01-24 10:33 ` Thomas Petazzoni 2017-01-09 8:43 ` [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Peter Korsgaard 1 sibling, 1 reply; 9+ messages in thread From: Romain Naour @ 2017-01-08 22:20 UTC (permalink / raw) To: buildroot The legacy entry was missing in commit [1]. [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> --- Config.in.legacy | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Config.in.legacy b/Config.in.legacy index 20445b8..8dfbbc8 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -145,6 +145,13 @@ endif ############################################################################### comment "Legacy options removed in 2017.02" +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX + bool "xserver AIGLX Extension removed" + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 + select BR2_LEGACY + help + The xserver AIGLX Extension has been removed in 1.19.0 release. + config BR2_PACKAGE_PERL_DB_FILE bool "perl-db-file removed" select BR2_LEGACY -- 2.9.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-08 22:20 ` [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 Romain Naour @ 2017-01-24 10:33 ` Thomas Petazzoni 2017-01-25 10:56 ` Arnout Vandecappelle 0 siblings, 1 reply; 9+ messages in thread From: Thomas Petazzoni @ 2017-01-24 10:33 UTC (permalink / raw) To: buildroot Hello, On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: > The legacy entry was missing in commit [1]. > > [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > Config.in.legacy | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Config.in.legacy b/Config.in.legacy > index 20445b8..8dfbbc8 100644 > --- a/Config.in.legacy > +++ b/Config.in.legacy > @@ -145,6 +145,13 @@ endif > ############################################################################### > comment "Legacy options removed in 2017.02" > > +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX > + bool "xserver AIGLX Extension removed" > + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 > + select BR2_LEGACY > + help > + The xserver AIGLX Extension has been removed in 1.19.0 release. Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this? Cc'ing Arnout and Yann, to get their insights. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-24 10:33 ` Thomas Petazzoni @ 2017-01-25 10:56 ` Arnout Vandecappelle 2017-01-25 19:29 ` Romain Naour 2017-01-26 20:59 ` Yann E. MORIN 0 siblings, 2 replies; 9+ messages in thread From: Arnout Vandecappelle @ 2017-01-25 10:56 UTC (permalink / raw) To: buildroot On 24-01-17 11:33, Thomas Petazzoni wrote: > Hello, > > On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >> The legacy entry was missing in commit [1]. >> >> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >> --- >> Config.in.legacy | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Config.in.legacy b/Config.in.legacy >> index 20445b8..8dfbbc8 100644 >> --- a/Config.in.legacy >> +++ b/Config.in.legacy >> @@ -145,6 +145,13 @@ endif >> ############################################################################### >> comment "Legacy options removed in 2017.02" >> >> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >> + bool "xserver AIGLX Extension removed" >> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >> + select BR2_LEGACY >> + help >> + The xserver AIGLX Extension has been removed in 1.19.0 release. > > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option > defined in two different places, with two different prompts. Do we > really want to do this? No we don't. We certainly don't want that changing some option (the server version) suddenly creates a legacy option. Also, legacy is not needed here: it never was possible (in a released buildroot) to select this option for v1.19.0+. Regards, Arnout > > Cc'ing Arnout and Yann, to get their insights. > > Thanks, > > Thomas > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-25 10:56 ` Arnout Vandecappelle @ 2017-01-25 19:29 ` Romain Naour 2017-01-26 10:38 ` Arnout Vandecappelle 2017-01-26 20:59 ` Yann E. MORIN 1 sibling, 1 reply; 9+ messages in thread From: Romain Naour @ 2017-01-25 19:29 UTC (permalink / raw) To: buildroot Hi Arnout, Thomas, All, Le 25/01/2017 ? 11:56, Arnout Vandecappelle a ?crit : > > On 24-01-17 11:33, Thomas Petazzoni wrote: >> Hello, >> >> On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >>> The legacy entry was missing in commit [1]. >>> >>> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >>> >>> Signed-off-by: Romain Naour <romain.naour@gmail.com> >>> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >>> --- >>> Config.in.legacy | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Config.in.legacy b/Config.in.legacy >>> index 20445b8..8dfbbc8 100644 >>> --- a/Config.in.legacy >>> +++ b/Config.in.legacy >>> @@ -145,6 +145,13 @@ endif >>> ############################################################################### >>> comment "Legacy options removed in 2017.02" >>> >>> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >>> + bool "xserver AIGLX Extension removed" >>> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >>> + select BR2_LEGACY >>> + help >>> + The xserver AIGLX Extension has been removed in 1.19.0 release. >> >> Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >> defined in two different places, with two different prompts. Do we >> really want to do this? > > No we don't. We certainly don't want that changing some option (the server > version) suddenly creates a legacy option. Indeed it's annoying... > > Also, legacy is not needed here: it never was possible (in a released > buildroot) to select this option for v1.19.0+. ...but the xserver package is special since we support several versions. If only one version was used, this option would be removed with the bump to 1.19.0 and a legacy entry added. If we previously used the latest xserver version (1.18.4) in 2016.11 with BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently removed from the defconfig with 2017.02. How we should handle new/old options when a package has several version available ? Best regards, Romain > > Regards, > Arnout > >> >> Cc'ing Arnout and Yann, to get their insights. >> >> Thanks, >> >> Thomas >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-25 19:29 ` Romain Naour @ 2017-01-26 10:38 ` Arnout Vandecappelle 0 siblings, 0 replies; 9+ messages in thread From: Arnout Vandecappelle @ 2017-01-26 10:38 UTC (permalink / raw) To: buildroot On 25-01-17 20:29, Romain Naour wrote: > Hi Arnout, Thomas, All, > > Le 25/01/2017 ? 11:56, Arnout Vandecappelle a ?crit : >> >> On 24-01-17 11:33, Thomas Petazzoni wrote: >>> Hello, >>> >>> On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: >>>> The legacy entry was missing in commit [1]. >>>> >>>> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 >>>> >>>> Signed-off-by: Romain Naour <romain.naour@gmail.com> >>>> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> >>>> --- >>>> Config.in.legacy | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/Config.in.legacy b/Config.in.legacy >>>> index 20445b8..8dfbbc8 100644 >>>> --- a/Config.in.legacy >>>> +++ b/Config.in.legacy >>>> @@ -145,6 +145,13 @@ endif >>>> ############################################################################### >>>> comment "Legacy options removed in 2017.02" >>>> >>>> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX >>>> + bool "xserver AIGLX Extension removed" >>>> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 >>>> + select BR2_LEGACY >>>> + help >>>> + The xserver AIGLX Extension has been removed in 1.19.0 release. >>> >>> Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >>> defined in two different places, with two different prompts. Do we >>> really want to do this? >> >> No we don't. We certainly don't want that changing some option (the server >> version) suddenly creates a legacy option. > > Indeed it's annoying... > >> >> Also, legacy is not needed here: it never was possible (in a released >> buildroot) to select this option for v1.19.0+. > > ...but the xserver package is special since we support several versions. > If only one version was used, this option would be removed with the bump to > 1.19.0 and a legacy entry added. > > If we previously used the latest xserver version (1.18.4) in 2016.11 with > BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently > removed from the defconfig with 2017.02. > > How we should handle new/old options when a package has several version available ? Well, normally the BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_18 legacy entry would force the user to select a different version, and it would be obvious that aiglx disappears in v1.19. However, we didn't add a legacy entry for v1.18... Regards, Arnout > > Best regards, > Romain > >> >> Regards, >> Arnout >> >>> >>> Cc'ing Arnout and Yann, to get their insights. >>> >>> Thanks, >>> >>> Thomas >>> >> > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-25 10:56 ` Arnout Vandecappelle 2017-01-25 19:29 ` Romain Naour @ 2017-01-26 20:59 ` Yann E. MORIN 2017-01-26 22:06 ` Peter Korsgaard 1 sibling, 1 reply; 9+ messages in thread From: Yann E. MORIN @ 2017-01-26 20:59 UTC (permalink / raw) To: buildroot On 2017-01-25 11:56 +0100, Arnout Vandecappelle spake thusly: > > > On 24-01-17 11:33, Thomas Petazzoni wrote: > > Hello, > > > > On Sun, 8 Jan 2017 23:20:11 +0100, Romain Naour wrote: > >> The legacy entry was missing in commit [1]. > >> > >> [1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4 > >> > >> Signed-off-by: Romain Naour <romain.naour@gmail.com> > >> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > >> --- > >> Config.in.legacy | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Config.in.legacy b/Config.in.legacy > >> index 20445b8..8dfbbc8 100644 > >> --- a/Config.in.legacy > >> +++ b/Config.in.legacy > >> @@ -145,6 +145,13 @@ endif > >> ############################################################################### > >> comment "Legacy options removed in 2017.02" > >> > >> +config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX > >> + bool "xserver AIGLX Extension removed" > >> + depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17 > >> + select BR2_LEGACY > >> + help > >> + The xserver AIGLX Extension has been removed in 1.19.0 release. > > > > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option > > defined in two different places, with two different prompts. Do we > > really want to do this? > > No we don't. We certainly don't want that changing some option (the server > version) suddenly creates a legacy option. My stake on this: - we must add a legacy entry for 1.18 - we must not add a legacy entry for AIGLX, because it is not yet legacy. It will turn legacy when the last xserver version we have that support AIGLX is dropped. For now, it is just an package option that is only available with some versions (1.17 and 1.14). > Also, legacy is not needed here: it never was possible (in a released > buildroot) to select this option for v1.19.0+. Agreed. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 2017-01-26 20:59 ` Yann E. MORIN @ 2017-01-26 22:06 ` Peter Korsgaard 0 siblings, 0 replies; 9+ messages in thread From: Peter Korsgaard @ 2017-01-26 22:06 UTC (permalink / raw) To: buildroot >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: Hi, >> > Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option >> > defined in two different places, with two different prompts. Do we >> > really want to do this? >> >> No we don't. We certainly don't want that changing some option (the server >> version) suddenly creates a legacy option. > My stake on this: > - we must add a legacy entry for 1.18 Ok. > - we must not add a legacy entry for AIGLX, because it is not yet > legacy. It will turn legacy when the last xserver version we have > that support AIGLX is dropped. For now, it is just an package option > that is only available with some versions (1.17 and 1.14). As I understood it, AIGLX support is now unconditionally enabled: https://cgit.freedesktop.org/xorg/xserver/commit/?id=501d8e2beb337e072c93c9310fcd927a099b9c3b So the legacy option would just state that this option is now unconditionally enabled. I'm not sure how helpful that is. The user is presumably already notified that the server version has changed (E.G. from 1.14/1.17 to 1.19+). -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] DEVELOPERS: Add entry for upower 2017-01-08 22:20 [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Romain Naour 2017-01-08 22:20 ` [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 Romain Naour @ 2017-01-09 8:43 ` Peter Korsgaard 1 sibling, 0 replies; 9+ messages in thread From: Peter Korsgaard @ 2017-01-09 8:43 UTC (permalink / raw) To: buildroot >>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > Signed-off-by: Romain Naour <romain.naour@gmail.com> Committed, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-01-26 22:06 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-01-08 22:20 [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Romain Naour 2017-01-08 22:20 ` [Buildroot] [PATCH] legacy/xserver: add a legacy entry for xserver >= 1.19.0 Romain Naour 2017-01-24 10:33 ` Thomas Petazzoni 2017-01-25 10:56 ` Arnout Vandecappelle 2017-01-25 19:29 ` Romain Naour 2017-01-26 10:38 ` Arnout Vandecappelle 2017-01-26 20:59 ` Yann E. MORIN 2017-01-26 22:06 ` Peter Korsgaard 2017-01-09 8:43 ` [Buildroot] [PATCH] DEVELOPERS: Add entry for upower Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox