From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/br2-external: fix use of relative paths
Date: Mon, 16 Jan 2017 18:52:38 +0100 [thread overview]
Message-ID: <20170116175238.GA3695@free.fr> (raw)
In-Reply-To: <87h94zcgg7.fsf@dell.be.48ers.dk>
Peter, All,
On 2017-01-16 13:55 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > When the path to a br2-external tree is relative, make enters an endless
> > recursive loop (paths elided for brevity):
>
> > $ make BR2_EXTERNAL=.. foo_defconfig
> > make[1]: stat: ../configs/../configs/../configs[...]/toto_defconfig: Filename too long
> > make[1]: *** No rule to make target '../configs/../configs/../configs[...]/toto_defconfig',
> > needed by '../configs/../configs/../configs[...]/toto_defconfig'. Stop.
> > Makefile:79: recipe for target '_all' failed
> > make: *** [_all] Error 2
>
> > It is a bit complex to understand the actual technical reason for this
> > never-ending expansion; it seems it happens in the code generated by the
> > percent_defconfig macro. Not sure why, though...
>
> > But the root cause is the relative path.
>
> > Just use absolute, canonical paths to br2-external trees. Always.
>
> > Reported-by: outtierbert at gmail.com
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Committed after adding to the commit message that this fixes #9576
Damn, right. Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2017-01-16 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 15:20 [Buildroot] [PATCH] core/br2-external: fix use of relative paths Yann E. MORIN
2017-01-16 12:55 ` Peter Korsgaard
2017-01-16 17:52 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116175238.GA3695@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox