[Buildroot] [PATCH] core/br2-external: fix use of relative paths

[Buildroot] [PATCH] core/br2-external: fix use of relative paths

[Yann E. MORIN]

When the path to a br2-external tree is relative, make enters an endless
recursive loop (paths elided for brevity):

    $ make BR2_EXTERNAL=.. foo_defconfig
    make[1]: stat: ../configs/../configs/../configs[...]/toto_defconfig: Filename too long
    make[1]: *** No rule to make target '../configs/../configs/../configs[...]/toto_defconfig',
    needed by '../configs/../configs/../configs[...]/toto_defconfig'.  Stop.
    Makefile:79: recipe for target '_all' failed
    make: *** [_all] Error 2

It is a bit complex to understand the actual technical reason for this
never-ending expansion; it seems it happens in the code generated by the
percent_defconfig macro. Not sure why, though...

But the root cause is the relative path.

Just use absolute, canonical paths to br2-external trees. Always.

Reported-by: outtierbert at gmail.com
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/br2-external | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/support/scripts/br2-external b/support/scripts/br2-external
index 84bc334..26bcac8 100755
--- a/support/scripts/br2-external
+++ b/support/scripts/br2-external
@@ -106,7 +106,8 @@ do_validate_one() {
         error "'%s/Config.in': no such file or directory\n" "${br2_ext}"
     fi
 
-    # Register this br2-external tree
+    # Register this br2-external tree, use an absolute canonical path
+    br2_ext="$( cd "${br2_ext}"; pwd )"
     BR2_EXT_NAMES+=( "${br2_name}" )
     eval BR2_EXT_PATHS_${br2_name}="\"\${br2_ext}\""
     eval BR2_EXT_DESCS_${br2_name}="\"\${br2_desc:-\${br2_name}}\""
-- 
2.7.4

[Buildroot] [PATCH] core/br2-external: fix use of relative paths

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When the path to a br2-external tree is relative, make enters an endless
 > recursive loop (paths elided for brevity):

 >     $ make BR2_EXTERNAL=.. foo_defconfig
 >     make[1]: stat: ../configs/../configs/../configs[...]/toto_defconfig: Filename too long
 >     make[1]: *** No rule to make target '../configs/../configs/../configs[...]/toto_defconfig',
 >     needed by '../configs/../configs/../configs[...]/toto_defconfig'.  Stop.
 >     Makefile:79: recipe for target '_all' failed
 >     make: *** [_all] Error 2

 > It is a bit complex to understand the actual technical reason for this
 > never-ending expansion; it seems it happens in the code generated by the
 > percent_defconfig macro. Not sure why, though...

 > But the root cause is the relative path.

 > Just use absolute, canonical paths to br2-external trees. Always.

 > Reported-by: outtierbert at gmail.com
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed after adding to the commit message that this fixes #9576

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] core/br2-external: fix use of relative paths

[Yann E. MORIN]

Peter, All,

On 2017-01-16 13:55 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > When the path to a br2-external tree is relative, make enters an endless
>  > recursive loop (paths elided for brevity):
> 
>  >     $ make BR2_EXTERNAL=.. foo_defconfig
>  >     make[1]: stat: ../configs/../configs/../configs[...]/toto_defconfig: Filename too long
>  >     make[1]: *** No rule to make target '../configs/../configs/../configs[...]/toto_defconfig',
>  >     needed by '../configs/../configs/../configs[...]/toto_defconfig'.  Stop.
>  >     Makefile:79: recipe for target '_all' failed
>  >     make: *** [_all] Error 2
> 
>  > It is a bit complex to understand the actual technical reason for this
>  > never-ending expansion; it seems it happens in the code generated by the
>  > percent_defconfig macro. Not sure why, though...
> 
>  > But the root cause is the relative path.
> 
>  > Just use absolute, canonical paths to br2-external trees. Always.
> 
>  > Reported-by: outtierbert at gmail.com
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Committed after adding to the commit message that this fixes #9576

Damn, right. Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'