* [Buildroot] [PATCH] SDL2_X11 depends on MMU (fork)
@ 2017-01-19 21:53 Romain Naour
2017-01-20 3:08 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2017-01-19 21:53 UTC (permalink / raw)
To: buildroot
From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Cc: baruch at tkos.co.il
Cc: romain.naour at gmail.com
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
Guillaume's email sent with git send-email seems rejected by the mailing list server...
---
package/sdl2/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
index b73611d..1d83c98 100644
--- a/package/sdl2/Config.in
+++ b/package/sdl2/Config.in
@@ -21,6 +21,7 @@ comment "DirectFB video driver needs directfb"
config BR2_PACKAGE_SDL2_X11
bool "X11 video driver"
depends on BR2_PACKAGE_XORG7
+ depends on BR2_USE_MMU # fork()
select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] SDL2_X11 depends on MMU (fork)
2017-01-19 21:53 [Buildroot] [PATCH] SDL2_X11 depends on MMU (fork) Romain Naour
@ 2017-01-20 3:08 ` Thomas Petazzoni
2017-01-20 9:50 ` Guillaume GARDET - Oliséo
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2017-01-20 3:08 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 19 Jan 2017 22:53:27 +0100, Romain Naour wrote:
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>
> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Cc: baruch at tkos.co.il
> Cc: romain.naour at gmail.com
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> Guillaume's email sent with git send-email seems rejected by the mailing list server...
> ---
> package/sdl2/Config.in | 1 +
> 1 file changed, 1 insertion(+)
I've applied, after fixing two things:
- The commit title did not comply with our usual practice, it was
lacking a package prefix, "sdl2: ".
- The depends on BR2_USE_MMU dependency was not provided to the
Config.in comment as it should have been.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] SDL2_X11 depends on MMU (fork)
2017-01-20 3:08 ` Thomas Petazzoni
@ 2017-01-20 9:50 ` Guillaume GARDET - Oliséo
0 siblings, 0 replies; 3+ messages in thread
From: Guillaume GARDET - Oliséo @ 2017-01-20 9:50 UTC (permalink / raw)
To: buildroot
Hello,
Le 20/01/2017 ? 04:08, Thomas Petazzoni a ?crit :
> Hello,
>
> On Thu, 19 Jan 2017 22:53:27 +0100, Romain Naour wrote:
>> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>>
>> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Cc: baruch at tkos.co.il
>> Cc: romain.naour at gmail.com
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>> Guillaume's email sent with git send-email seems rejected by the mailing list server...
>> ---
>> package/sdl2/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
> I've applied, after fixing two things:
Thanks.
>
> - The commit title did not comply with our usual practice, it was
> lacking a package prefix, "sdl2: ".
>
> - The depends on BR2_USE_MMU dependency was not provided to the
> Config.in comment as it should have been.
Thanks for fixing both.
Guillaume
>
> Thanks a lot!
>
> Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-20 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 21:53 [Buildroot] [PATCH] SDL2_X11 depends on MMU (fork) Romain Naour
2017-01-20 3:08 ` Thomas Petazzoni
2017-01-20 9:50 ` Guillaume GARDET - Oliséo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox