Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] busybox: add comment that other packages are needed
@ 2017-01-17 22:58 Arnout Vandecappelle
  2017-01-20  3:12 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2017-01-17 22:58 UTC (permalink / raw)
  To: buildroot

Inspired on the confusion in [1], we want to warn the user that building
without busybox may not lead to a working system.

[1] https://bugs.busybox.net/show_bug.cgi?id=9526

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Better wording is certainly welcome!
---
 package/busybox/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/busybox/Config.in b/package/busybox/Config.in
index 7ef3f0eda8..504cd8a65a 100644
--- a/package/busybox/Config.in
+++ b/package/busybox/Config.in
@@ -77,6 +77,9 @@ endif
 
 if !BR2_PACKAGE_BUSYBOX # kconfig doesn't support else
 
+comment "You may need to enable other packages to get a working system"
+comment "You better know what you're doing!"
+
 # This option is not an option of Busybox, it can be selected even if
 # Busybox is not enabled. This dummy option ensures that packages that
 # depend on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS are visible when Busybox
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] busybox: add comment that other packages are needed
  2017-01-17 22:58 [Buildroot] [PATCH] busybox: add comment that other packages are needed Arnout Vandecappelle
@ 2017-01-20  3:12 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-01-20  3:12 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 17 Jan 2017 23:58:54 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> Inspired on the confusion in [1], we want to warn the user that building
> without busybox may not lead to a working system.
> 
> [1] https://bugs.busybox.net/show_bug.cgi?id=9526
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Better wording is certainly welcome!
> ---
>  package/busybox/Config.in | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-20  3:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 22:58 [Buildroot] [PATCH] busybox: add comment that other packages are needed Arnout Vandecappelle
2017-01-20  3:12 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox