Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 1/3] pkg-perl: add PREFER_INSTALLER variable
Date: Tue, 24 Jan 2017 22:20:10 +1300	[thread overview]
Message-ID: <20170124222010.2a6acb8f@free-electrons.com> (raw)
In-Reply-To: <20170124082534.21033-1-francois.perrad@gadz.org>

Hello,

On Tue, 24 Jan 2017 09:25:32 +0100, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  docs/manual/adding-packages-perl.txt |  8 ++++++--
>  package/pkg-perl.mk                  | 20 ++++++++++++++------
>  2 files changed, 20 insertions(+), 8 deletions(-)

Thanks for this v2, but I've already reviewed and it doesn't seem like
you have taken into account my comments. There has been no reply from
you to the comments I made on the v1, and there is no changelog in your
v2 to understand what has changed compared to v1.

When there are review comments, it would be useful if you could *reply*
rather than just sending a new version that fixes some of the comments
and totally ignores the rest of the comments ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2017-01-24  9:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  8:25 [Buildroot] [V2 1/3] pkg-perl: add PREFER_INSTALLER variable Francois Perrad
2017-01-24  8:25 ` [Buildroot] [V2 2/3] perl-gd: bump to version 2.56 Francois Perrad
2017-01-24  8:25 ` [Buildroot] [V2 3/3] perl-gdgraph: bump to version 1.54 Francois Perrad
2017-01-24  9:20 ` Thomas Petazzoni [this message]
2017-01-29 13:59 ` [Buildroot] [V2 1/3] pkg-perl: add PREFER_INSTALLER variable Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124222010.2a6acb8f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox