* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
@ 2017-01-18 18:58 Bryce Ferguson
2017-01-18 19:03 ` Bryce Ferguson
2017-01-24 9:24 ` Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Bryce Ferguson @ 2017-01-18 18:58 UTC (permalink / raw)
To: buildroot
Added the pure-ftp quotas option. When selected, the --with-quotas
compiler option is passed which enables the quota feature
Note that this increases the size of the pure-ftpd executable by
about 20%.
Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
---
package/pure-ftpd/Config.in | 7 +++++++
package/pure-ftpd/pure-ftpd.mk | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/package/pure-ftpd/Config.in b/package/pure-ftpd/Config.in
index 85fdef3..df28c4c 100644
--- a/package/pure-ftpd/Config.in
+++ b/package/pure-ftpd/Config.in
@@ -20,4 +20,11 @@ config BR2_PACKAGE_PURE_FTPD_FTPWHO
client sessions. Only the system administrator may run this. Output
can be text (default), HTML, XML data and parser-optimized.
+config BR2_PACKAGE_PURE_FTPD_QUOTAS
+ bool "quotas"
+ help
+ Enable virtual quotas. With virtual quotas, restrictions can be placed
+ on the maximum number of files a user can store in his account. In
+ addition, restrictions can also be placed on the total size.
+
endif
diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
index 80e432a..95e7065 100644
--- a/package/pure-ftpd/pure-ftpd.mk
+++ b/package/pure-ftpd/pure-ftpd.mk
@@ -49,4 +49,8 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_FTPWHO),y)
PURE_FTPD_CONF_OPTS += --with-ftpwho
endif
+ifeq ($(BR2_PACKAGE_PURE_FTPD_QUOTAS),y)
+PURE_FTPD_CONF_OPTS += --with-quotas
+endif
+
$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
2017-01-18 18:58 [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option Bryce Ferguson
@ 2017-01-18 19:03 ` Bryce Ferguson
2017-01-24 9:24 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Bryce Ferguson @ 2017-01-18 19:03 UTC (permalink / raw)
To: buildroot
On Wed, Jan 18, 2017 at 12:58 PM, Bryce Ferguson
<bryce.ferguson@rockwellcollins.com> wrote:
> Added the pure-ftp quotas option. When selected, the --with-quotas
> compiler option is passed which enables the quota feature
>
> Note that this increases the size of the pure-ftpd executable by
> about 20%.
Added the note about the executable size difference as per Baruch's
comments (https://patchwork.ozlabs.org/patch/711541/) and marked
original as superseded.
>
> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
> ---
> package/pure-ftpd/Config.in | 7 +++++++
> package/pure-ftpd/pure-ftpd.mk | 4 ++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/package/pure-ftpd/Config.in b/package/pure-ftpd/Config.in
> index 85fdef3..df28c4c 100644
> --- a/package/pure-ftpd/Config.in
> +++ b/package/pure-ftpd/Config.in
> @@ -20,4 +20,11 @@ config BR2_PACKAGE_PURE_FTPD_FTPWHO
> client sessions. Only the system administrator may run this. Output
> can be text (default), HTML, XML data and parser-optimized.
>
> +config BR2_PACKAGE_PURE_FTPD_QUOTAS
> + bool "quotas"
> + help
> + Enable virtual quotas. With virtual quotas, restrictions can be placed
> + on the maximum number of files a user can store in his account. In
> + addition, restrictions can also be placed on the total size.
> +
> endif
> diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
> index 80e432a..95e7065 100644
> --- a/package/pure-ftpd/pure-ftpd.mk
> +++ b/package/pure-ftpd/pure-ftpd.mk
> @@ -49,4 +49,8 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_FTPWHO),y)
> PURE_FTPD_CONF_OPTS += --with-ftpwho
> endif
>
> +ifeq ($(BR2_PACKAGE_PURE_FTPD_QUOTAS),y)
> +PURE_FTPD_CONF_OPTS += --with-quotas
> +endif
> +
> $(eval $(autotools-package))
> --
> 1.9.1
>
--
Bryce Ferguson
Software Engineer
Airborne Information Solutions \ Secure Platforms
400 Collins Rd NE Cedar Rapids, Iowa 52498
Bryce.Ferguson at rockwellcollins.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
2017-01-18 18:58 [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option Bryce Ferguson
2017-01-18 19:03 ` Bryce Ferguson
@ 2017-01-24 9:24 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2017-01-24 9:24 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 18 Jan 2017 12:58:51 -0600, Bryce Ferguson wrote:
> Added the pure-ftp quotas option. When selected, the --with-quotas
> compiler option is passed which enables the quota feature
>
> Note that this increases the size of the pure-ftpd executable by
> about 20%.
>
> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
> ---
> package/pure-ftpd/Config.in | 7 +++++++
> package/pure-ftpd/pure-ftpd.mk | 4 ++++
> 2 files changed, 11 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
@ 2017-01-05 18:41 Bryce Ferguson
2017-01-05 18:49 ` Baruch Siach
0 siblings, 1 reply; 7+ messages in thread
From: Bryce Ferguson @ 2017-01-05 18:41 UTC (permalink / raw)
To: buildroot
Added the pure-ftp quotas option. When selected, the --with-quotas
compiler option is passed which enables the quota feature.
Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
---
package/pure-ftpd/Config.in | 7 +++++++
package/pure-ftpd/pure-ftpd.mk | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/package/pure-ftpd/Config.in b/package/pure-ftpd/Config.in
index 85fdef3..df28c4c 100644
--- a/package/pure-ftpd/Config.in
+++ b/package/pure-ftpd/Config.in
@@ -20,4 +20,11 @@ config BR2_PACKAGE_PURE_FTPD_FTPWHO
client sessions. Only the system administrator may run this. Output
can be text (default), HTML, XML data and parser-optimized.
+config BR2_PACKAGE_PURE_FTPD_QUOTAS
+ bool "quotas"
+ help
+ Enable virtual quotas. With virtual quotas, restrictions can be placed
+ on the maximum number of files a user can store in his account. In
+ addition, restrictions can also be placed on the total size.
+
endif
diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
index 80e432a..95e7065 100644
--- a/package/pure-ftpd/pure-ftpd.mk
+++ b/package/pure-ftpd/pure-ftpd.mk
@@ -49,4 +49,8 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_FTPWHO),y)
PURE_FTPD_CONF_OPTS += --with-ftpwho
endif
+ifeq ($(BR2_PACKAGE_PURE_FTPD_QUOTAS),y)
+PURE_FTPD_CONF_OPTS += --with-quotas
+endif
+
$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
2017-01-05 18:41 Bryce Ferguson
@ 2017-01-05 18:49 ` Baruch Siach
2017-01-06 14:49 ` Bryce Ferguson
0 siblings, 1 reply; 7+ messages in thread
From: Baruch Siach @ 2017-01-05 18:49 UTC (permalink / raw)
To: buildroot
Hi Bryce,
On Thu, Jan 05, 2017 at 12:41:54PM -0600, Bryce Ferguson wrote:
> Added the pure-ftp quotas option. When selected, the --with-quotas
> compiler option is passed which enables the quota feature.
>
> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
> ---
> package/pure-ftpd/Config.in | 7 +++++++
> package/pure-ftpd/pure-ftpd.mk | 4 ++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/package/pure-ftpd/Config.in b/package/pure-ftpd/Config.in
> index 85fdef3..df28c4c 100644
> --- a/package/pure-ftpd/Config.in
> +++ b/package/pure-ftpd/Config.in
> @@ -20,4 +20,11 @@ config BR2_PACKAGE_PURE_FTPD_FTPWHO
> client sessions. Only the system administrator may run this. Output
> can be text (default), HTML, XML data and parser-optimized.
>
> +config BR2_PACKAGE_PURE_FTPD_QUOTAS
> + bool "quotas"
> + help
> + Enable virtual quotas. With virtual quotas, restrictions can be placed
> + on the maximum number of files a user can store in his account. In
> + addition, restrictions can also be placed on the total size.
What is the impact of this feature on executable size? In case the impact is
small compared to the size of pure-ftpd itself, the general preference in
Buildroot is to just enable the feature unconditionally.
baruch
> +
> endif
> diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
> index 80e432a..95e7065 100644
> --- a/package/pure-ftpd/pure-ftpd.mk
> +++ b/package/pure-ftpd/pure-ftpd.mk
> @@ -49,4 +49,8 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_FTPWHO),y)
> PURE_FTPD_CONF_OPTS += --with-ftpwho
> endif
>
> +ifeq ($(BR2_PACKAGE_PURE_FTPD_QUOTAS),y)
> +PURE_FTPD_CONF_OPTS += --with-quotas
> +endif
> +
> $(eval $(autotools-package))
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
2017-01-05 18:49 ` Baruch Siach
@ 2017-01-06 14:49 ` Bryce Ferguson
2017-01-07 18:16 ` Baruch Siach
0 siblings, 1 reply; 7+ messages in thread
From: Bryce Ferguson @ 2017-01-06 14:49 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, Jan 5, 2017 at 12:49 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Bryce,
>
> On Thu, Jan 05, 2017 at 12:41:54PM -0600, Bryce Ferguson wrote:
>> Added the pure-ftp quotas option. When selected, the --with-quotas
>> compiler option is passed which enables the quota feature.
>>
>> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
>> ---
>> package/pure-ftpd/Config.in | 7 +++++++
>> package/pure-ftpd/pure-ftpd.mk | 4 ++++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/package/pure-ftpd/Config.in b/package/pure-ftpd/Config.in
>> index 85fdef3..df28c4c 100644
>> --- a/package/pure-ftpd/Config.in
>> +++ b/package/pure-ftpd/Config.in
>> @@ -20,4 +20,11 @@ config BR2_PACKAGE_PURE_FTPD_FTPWHO
>> client sessions. Only the system administrator may run this. Output
>> can be text (default), HTML, XML data and parser-optimized.
>>
>> +config BR2_PACKAGE_PURE_FTPD_QUOTAS
>> + bool "quotas"
>> + help
>> + Enable virtual quotas. With virtual quotas, restrictions can be placed
>> + on the maximum number of files a user can store in his account. In
>> + addition, restrictions can also be placed on the total size.
>
> What is the impact of this feature on executable size? In case the impact is
> small compared to the size of pure-ftpd itself, the general preference in
> Buildroot is to just enable the feature unconditionally.
>
> baruch
I did a build test, one with the feature and one without. When this
feature is enabled, the executable size increases by a little over
20%. Hope that helps, thanks for the feedback.
- Bryce
>
>> +
>> endif
>> diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
>> index 80e432a..95e7065 100644
>> --- a/package/pure-ftpd/pure-ftpd.mk
>> +++ b/package/pure-ftpd/pure-ftpd.mk
>> @@ -49,4 +49,8 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_FTPWHO),y)
>> PURE_FTPD_CONF_OPTS += --with-ftpwho
>> endif
>>
>> +ifeq ($(BR2_PACKAGE_PURE_FTPD_QUOTAS),y)
>> +PURE_FTPD_CONF_OPTS += --with-quotas
>> +endif
>> +
>> $(eval $(autotools-package))
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
Bryce Ferguson
Software Engineer
Airborne Information Solutions \ Secure Platforms
400 Collins Rd NE Cedar Rapids, Iowa 52498
Bryce.Ferguson at rockwellcollins.com
^ permalink raw reply [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option
2017-01-06 14:49 ` Bryce Ferguson
@ 2017-01-07 18:16 ` Baruch Siach
0 siblings, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2017-01-07 18:16 UTC (permalink / raw)
To: buildroot
Hi Bryce,
On Fri, Jan 06, 2017 at 08:49:43AM -0600, Bryce Ferguson wrote:
> On Thu, Jan 5, 2017 at 12:49 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Thu, Jan 05, 2017 at 12:41:54PM -0600, Bryce Ferguson wrote:
> >> +config BR2_PACKAGE_PURE_FTPD_QUOTAS
> >> + bool "quotas"
> >> + help
> >> + Enable virtual quotas. With virtual quotas, restrictions can be placed
> >> + on the maximum number of files a user can store in his account. In
> >> + addition, restrictions can also be placed on the total size.
> >
> > What is the impact of this feature on executable size? In case the impact is
> > small compared to the size of pure-ftpd itself, the general preference in
> > Buildroot is to just enable the feature unconditionally.
>
> I did a build test, one with the feature and one without. When this
> feature is enabled, the executable size increases by a little over
> 20%. Hope that helps, thanks for the feedback.
This size increase is worth an additional config option, IMO. Please put this
information in the commit log.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-24 9:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 18:58 [Buildroot] [PATCH 1/1] pure-ftpd: Added pure-ftpd quotas config option Bryce Ferguson
2017-01-18 19:03 ` Bryce Ferguson
2017-01-24 9:24 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2017-01-05 18:41 Bryce Ferguson
2017-01-05 18:49 ` Baruch Siach
2017-01-06 14:49 ` Bryce Ferguson
2017-01-07 18:16 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox