[Buildroot] [V2 1/1] sngrep: new package

[Buildroot] [V2 1/1] sngrep: new package

[Adam Duskett]

sngrep is a tool for displaying SIP calls message flows from terminal.
It supports live capture to display realtime SIP packets and can also
be used as PCAP viewer.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 - v2:
 - Added select BR2_PACKAGE_NCURSES_WCHAR.
 - Added select BR2_PACKAGE_NCURSES_TARGET_PANEL
 - Added select BR2_PACKAGE_NCURSES_TARGET_FORM
 - Added select BR2_PACKAGE_NCURSES_TARGET_MENU
 - Changed version downloaded to v1.4.2 (I didn't see the release tab!)

 package/Config.in          |  1 +
 package/sngrep/Config.in   | 17 +++++++++++++++++
 package/sngrep/sngrep.hash |  1 +
 package/sngrep/sngrep.mk   | 14 ++++++++++++++
 4 files changed, 33 insertions(+)
 create mode 100644 package/sngrep/Config.in
 create mode 100644 package/sngrep/sngrep.hash
 create mode 100644 package/sngrep/sngrep.mk

diff --git a/package/Config.in b/package/Config.in
index c7b6862..0572110 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1625,6 +1625,7 @@ endif
 	source "package/shairport-sync/Config.in"
 	source "package/shellinabox/Config.in"
 	source "package/smcroute/Config.in"
+	source "package/sngrep/Config.in"
 	source "package/socat/Config.in"
 	source "package/socketcand/Config.in"
 	source "package/softether/Config.in"
diff --git a/package/sngrep/Config.in b/package/sngrep/Config.in
new file mode 100644
index 0000000..a976cea
--- /dev/null
+++ b/package/sngrep/Config.in
@@ -0,0 +1,17 @@
+comment "sngrep needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+
+config BR2_PACKAGE_SNGREP
+	bool "sngrep"
+	select BR2_PACKAGE_NCURSES_WCHAR
+	select BR2_PACKAGE_NCURSES_TARGET_PANEL
+	select BR2_PACKAGE_NCURSES_TARGET_FORM
+	select BR2_PACKAGE_NCURSES_TARGET_MENU
+	depends on BR2_PACKAGE_LIBPCAP
+	depends on BR2_PACKAGE_NCURSES
+	help
+	  sngrep is a tool for displaying SIP calls message flows from terminal.
+	  It supports live capture to display realtime SIP packets and can also be 
+	  used as PCAP viewer.
+
diff --git a/package/sngrep/sngrep.hash b/package/sngrep/sngrep.hash
new file mode 100644
index 0000000..dd75f89
--- /dev/null
+++ b/package/sngrep/sngrep.hash
@@ -0,0 +1 @@
+sha256 30fbfb4f90ed8805194b39683a8a2ed465776ffd60df4482bd029d63b316b3f1 sngrep-v1.4.2.tar.gz
diff --git a/package/sngrep/sngrep.mk b/package/sngrep/sngrep.mk
new file mode 100644
index 0000000..c3d4ca5
--- /dev/null
+++ b/package/sngrep/sngrep.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# sngrep
+#
+################################################################################
+
+SNGREP_VERSION = v1.4.2
+SNGREP_SITE = $(call github,irontec,sngrep,$(SNGREP_VERSION))
+SNGREP_LICENSE = GPLv3+
+SNGREP_LICENSE_FILES = LICENSE
+SNGREP_AUTORECONF = YES
+SNGREP_DEPENDENCIES = libpcap ncurses
+
+$(eval $(autotools-package))
-- 
2.9.3

[Buildroot] [V2 1/1] sngrep: new package

[Baruch Siach]

Hi Adam,

On Wed, Jan 25, 2017 at 09:09:04AM -0500, Adam Duskett wrote:
> diff --git a/package/sngrep/Config.in b/package/sngrep/Config.in
> new file mode 100644
> index 0000000..a976cea
> --- /dev/null
> +++ b/package/sngrep/Config.in
> @@ -0,0 +1,17 @@
> +comment "sngrep needs a toolchain w/ wchar, threads"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

This comment does not match that actual dependencies below.

> +
> +

Redundant empty line.

> +config BR2_PACKAGE_SNGREP
> +	bool "sngrep"
> +	select BR2_PACKAGE_NCURSES_WCHAR
> +	select BR2_PACKAGE_NCURSES_TARGET_PANEL
> +	select BR2_PACKAGE_NCURSES_TARGET_FORM
> +	select BR2_PACKAGE_NCURSES_TARGET_MENU
> +	depends on BR2_PACKAGE_LIBPCAP
> +	depends on BR2_PACKAGE_NCURSES

These should be select.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [V2 1/1] sngrep: new package

[Baruch Siach]

Hi Adam,

On Wed, Jan 25, 2017 at 02:46:47PM +0000, Adam Duskett wrote:
> On Wed, 2017-01-25 at 16:44 +0200, Baruch Siach wrote:
> > On Wed, Jan 25, 2017 at 09:09:04AM -0500, Adam Duskett wrote:
> > > +config BR2_PACKAGE_SNGREP
> > > +	bool "sngrep"
> > > +	select BR2_PACKAGE_NCURSES_WCHAR
> > > +	select BR2_PACKAGE_NCURSES_TARGET_PANEL
> > > +	select BR2_PACKAGE_NCURSES_TARGET_FORM
> > > +	select BR2_PACKAGE_NCURSES_TARGET_MENU
> > > +	depends on BR2_PACKAGE_LIBPCAP
> > > +	depends on BR2_PACKAGE_NCURSES
> > 
> > These should be select.
> Could I ask a question?
> When should I use depends on and when should I use select?
> I am not sure what the rules are on this.

See section 17.2.3 (Choosing depends on or select) in the manual[1].

[1] http://nightly.buildroot.org/manual.html

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -