Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/libasplib: bump version
@ 2017-01-01 12:02 Bernd Kuhls
  2017-01-01 12:02 ` [Buildroot] [PATCH 2/2] package/libasplib: fix build error on m68k Bernd Kuhls
  2017-01-25  3:44 ` [Buildroot] [PATCH 1/2] package/libasplib: bump version Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2017-01-01 12:02 UTC (permalink / raw)
  To: buildroot

libasplib now contains modules, we enable only those for the moment
which do not need external dependencies. We are not in a hurry to fully
support all features of this package because the upcoming Kodi release
17.x-Krypton will not carry any ADSP add-ons:
https://github.com/xbmc/repo-binary-addons/commit/db3b767309df25daae4f01f01dba85ca7b3464b0

-DASPLIB_MODULES_TO_BUILD=some looks hackish because the default is to
enable all modules:
https://github.com/AchimTuran/asplib/blob/master/CMakeLists.txt#L35

But -DASPLIB_MODULES_TO_BUILD=OFF does not disable the build of all
modules as well because of
https://github.com/AchimTuran/asplib/blob/master/asplib_modules/CMakeLists.txt#L19
so I added "some" as fake value.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libasplib/libasplib.hash |  2 +-
 package/libasplib/libasplib.mk   | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/package/libasplib/libasplib.hash b/package/libasplib/libasplib.hash
index bbd027dda..76534e528 100644
--- a/package/libasplib/libasplib.hash
+++ b/package/libasplib/libasplib.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 ccc2718c79a8d684317cc1987ede88b198e1602df47d0f18f03d474eda00af9c libasplib-f7219142e790a329b002a94f3db943abcb183739.tar.gz
+sha256 68e117348fa17592dde7672477e927119a0e477103ced1d3a57d92e30880a147  libasplib-be7fac89218a84b75f7598e3d76625ece99296f2.tar.gz
diff --git a/package/libasplib/libasplib.mk b/package/libasplib/libasplib.mk
index 41aeaeb8a..038fc389e 100644
--- a/package/libasplib/libasplib.mk
+++ b/package/libasplib/libasplib.mk
@@ -4,10 +4,18 @@
 #
 ################################################################################
 
-LIBASPLIB_VERSION = f7219142e790a329b002a94f3db943abcb183739
+LIBASPLIB_VERSION = be7fac89218a84b75f7598e3d76625ece99296f2
 LIBASPLIB_SITE = $(call github,AchimTuran,asplib,$(LIBASPLIB_VERSION))
 LIBASPLIB_LICENSE = GPLv3+
 LIBASPLIB_LICENSE_FILES = LICENSE
 LIBASPLIB_INSTALL_STAGING = YES
 
+LIBASPLIB_CONF_OPTS = \
+	-DASPLIB_MODULES_TO_BUILD=some \
+	-DBUILD_BIQUAD=ON \
+	-DBUILD_IIR=ON \
+	-DBUILD_LOGGER=ON \
+	-DBUILD_SIGNALS=ON \
+	-DBUILD_TIMER=ON
+
 $(eval $(cmake-package))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/libasplib: fix build error on m68k
  2017-01-01 12:02 [Buildroot] [PATCH 1/2] package/libasplib: bump version Bernd Kuhls
@ 2017-01-01 12:02 ` Bernd Kuhls
  2017-01-25  3:44 ` [Buildroot] [PATCH 1/2] package/libasplib: bump version Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2017-01-01 12:02 UTC (permalink / raw)
  To: buildroot

Patch written by Waldemar Brodkorb:
http://lists.busybox.net/pipermail/buildroot/2016-November/177726.html

This patch however did not work: "Unfortunately libasplib cmake
infrastructure ignores my CMAKE_CXX_FLAGS."

To make this patch work libasplib needed to be bumped because the cmake
infrastructure was updated back in August 2016 which fixed the problem:
https://github.com/AchimTuran/asplib/commit/6326d1f5e8dad9fd9947b7f4688ddddda91e9e9e

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libasplib/libasplib.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libasplib/libasplib.mk b/package/libasplib/libasplib.mk
index 038fc389e..b3b1fdb30 100644
--- a/package/libasplib/libasplib.mk
+++ b/package/libasplib/libasplib.mk
@@ -18,4 +18,11 @@ LIBASPLIB_CONF_OPTS = \
 	-DBUILD_SIGNALS=ON \
 	-DBUILD_TIMER=ON
 
+# Internal error, aborting at dw2gencfi.c:214 in emit_expr_encoded
+ifeq ($(BR2_m68k_cf),y)
+LIBASPLIB_CXXFLAGS += -fno-dwarf2-cfi-asm
+endif
+
+LIBASPLIB_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) $(LIBASPLIB_CXXFLAGS)"
+
 $(eval $(cmake-package))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/2] package/libasplib: bump version
  2017-01-01 12:02 [Buildroot] [PATCH 1/2] package/libasplib: bump version Bernd Kuhls
  2017-01-01 12:02 ` [Buildroot] [PATCH 2/2] package/libasplib: fix build error on m68k Bernd Kuhls
@ 2017-01-25  3:44 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-01-25  3:44 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  1 Jan 2017 13:02:43 +0100, Bernd Kuhls wrote:
> libasplib now contains modules, we enable only those for the moment
> which do not need external dependencies. We are not in a hurry to fully
> support all features of this package because the upcoming Kodi release
> 17.x-Krypton will not carry any ADSP add-ons:
> https://github.com/xbmc/repo-binary-addons/commit/db3b767309df25daae4f01f01dba85ca7b3464b0
> 
> -DASPLIB_MODULES_TO_BUILD=some looks hackish because the default is to
> enable all modules:
> https://github.com/AchimTuran/asplib/blob/master/CMakeLists.txt#L35
> 
> But -DASPLIB_MODULES_TO_BUILD=OFF does not disable the build of all
> modules as well because of
> https://github.com/AchimTuran/asplib/blob/master/asplib_modules/CMakeLists.txt#L19
> so I added "some" as fake value.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/libasplib/libasplib.hash |  2 +-
>  package/libasplib/libasplib.mk   | 10 +++++++++-
>  2 files changed, 10 insertions(+), 2 deletions(-)

Both patches applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-25  3:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-01 12:02 [Buildroot] [PATCH 1/2] package/libasplib: bump version Bernd Kuhls
2017-01-01 12:02 ` [Buildroot] [PATCH 2/2] package/libasplib: fix build error on m68k Bernd Kuhls
2017-01-25  3:44 ` [Buildroot] [PATCH 1/2] package/libasplib: bump version Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox