[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Alexey Neyman]

The shorter alias, -std=c90, is not known by older versions of GCC.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20631.

Signed-off-by: Alexey Neyman <stilor@att.net>
---
 package/ucl/ucl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ucl/ucl.mk b/package/ucl/ucl.mk
index e4dc1b3..b183a13 100644
--- a/package/ucl/ucl.mk
+++ b/package/ucl/ucl.mk
@@ -10,6 +10,6 @@ UCL_LICENSE = GPLv2+
 UCL_LICENSE_FILES = COPYING
 
 # Fix ACC conformance test failure for host gcc 6.x
-HOST_UCL_CONF_ENV += CPPFLAGS="$(HOST_CPPFLAGS) -std=c90"
+HOST_UCL_CONF_ENV += CPPFLAGS="$(HOST_CPPFLAGS) -std=iso9899:1990"
 
 $(eval $(host-autotools-package))
-- 
2.9.3

[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Thomas Petazzoni]

Hello,

On Wed, 25 Jan 2017 11:20:20 -0800, Alexey Neyman wrote:
> The shorter alias, -std=c90, is not known by older versions of GCC.
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20631.
> 
> Signed-off-by: Alexey Neyman <stilor@att.net>

Thanks for the patch. Is this fixing a specific autobuilder issue? In
which situation have you seen the failure?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Alexey Neyman]

On 01/25/2017 02:01 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 25 Jan 2017 11:20:20 -0800, Alexey Neyman wrote:
>> The shorter alias, -std=c90, is not known by older versions of GCC.
>> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20631.
>>
>> Signed-off-by: Alexey Neyman <stilor@att.net>
> Thanks for the patch. Is this fixing a specific autobuilder issue? In
> which situation have you seen the failure?
Issue observed on a CentOS6.x build machine, which has GCC 4.4. The 
--std=c90 appeared in 4.5.

Regards,
Alexey.

[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Thomas Petazzoni]

Hello,

On Wed, 25 Jan 2017 11:20:20 -0800, Alexey Neyman wrote:
> The shorter alias, -std=c90, is not known by older versions of GCC.
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20631.
> 
> Signed-off-by: Alexey Neyman <stilor@att.net>
> ---
>  package/ucl/ucl.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] ucl: Use -std=iso9899:1990 instead of -std=c90

[Thomas Petazzoni]

Hello,

On Wed, 25 Jan 2017 15:56:06 -0800, Alexey Neyman wrote:

> Issue observed on a CentOS6.x build machine, which has GCC 4.4. The 
> --std=c90 appeared in 4.5.

OK. I was surprised because my autobuilder instance also uses GCC 4.4
as the host compiler, and the build failure was never detected.

But host-ucl is only used as a dependency of host-upx, which itself is
also only used as a dependency of syslinux. Since syslinux is a
bootloader, it does not get build tested by the autobuilders.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com