From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/fbterm: Fix building against libiconv
Date: Sun, 29 Jan 2017 14:26:33 +0100 [thread overview]
Message-ID: <20170129142633.4ba3c0b4@free-electrons.com> (raw)
In-Reply-To: <20170128174916.11214-1-bernd.kuhls@t-online.de>
Hello,
On Sat, 28 Jan 2017 18:49:16 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/d5d/d5d9705eea16f07848a313d9c83f491569734c5d/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/fbterm/0004-iconv.patch | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 package/fbterm/0004-iconv.patch
Applied to master, thanks. However, this means that fbterm links
against libiconv when available, no? So perhaps we should have:
ifeq ($(BR2_PACKAGE_LIBICONV),y)
FBTERM_DEPENDENCIES += libiconv
endif
in fbterm.mk ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-29 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 17:49 [Buildroot] [PATCH 1/1] package/fbterm: Fix building against libiconv Bernd Kuhls
2017-01-29 13:26 ` Thomas Petazzoni [this message]
2017-01-29 14:37 ` Bernd Kuhls
2017-01-29 15:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129142633.4ba3c0b4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox