From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/fbterm: Fix building against libiconv
Date: Sun, 29 Jan 2017 15:37:33 +0100 [thread overview]
Message-ID: <dab1mdxd4l.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: 20170129142633.4ba3c0b4@free-electrons.com
Am Sun, 29 Jan 2017 14:26:33 +0100 schrieb Thomas Petazzoni:
> Applied to master, thanks. However, this means that fbterm links against
> libiconv when available, no? So perhaps we should have:
>
> ifeq ($(BR2_PACKAGE_LIBICONV),y)
> FBTERM_DEPENDENCIES += libiconv endif
>
> in fbterm.mk ?
Hi,
I think this is not needed, because fbterm depends on BR2_ENABLE_LOCALE,
while libiconv depends on !BR2_ENABLE_LOCALE. The build error occured
while including iconv.h from uClibc.
Regards, Bernd
next prev parent reply other threads:[~2017-01-29 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 17:49 [Buildroot] [PATCH 1/1] package/fbterm: Fix building against libiconv Bernd Kuhls
2017-01-29 13:26 ` Thomas Petazzoni
2017-01-29 14:37 ` Bernd Kuhls [this message]
2017-01-29 15:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab1mdxd4l.ln2@ID-313208.user.individual.net \
--to=bernd.kuhls@t-online.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox