Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] dbus: remove init script status op
@ 2017-02-01 14:34 Baruch Siach
  2017-02-01 20:16 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2017-02-01 14:34 UTC (permalink / raw)
  To: buildroot

There is no status() shell routine in this script.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/dbus/S30dbus | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/package/dbus/S30dbus b/package/dbus/S30dbus
index 4427b5c72c0a..b4bcf9c7aa9a 100644
--- a/package/dbus/S30dbus
+++ b/package/dbus/S30dbus
@@ -53,10 +53,6 @@ case "$1" in
     stop)
         stop
         ;;
-    status)
-        status $processname
-        RETVAL=$?
-        ;;
     restart)
         stop
         start
@@ -72,7 +68,7 @@ case "$1" in
         RETVAL=$?
         ;;
     *)
-        echo "Usage: $0 {start|stop|status|restart|condrestart|reload}"
+        echo "Usage: $0 {start|stop|restart|condrestart|reload}"
         ;;
 esac
 exit $RETVAL
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] dbus: remove init script status op
  2017-02-01 14:34 [Buildroot] [PATCH] dbus: remove init script status op Baruch Siach
@ 2017-02-01 20:16 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-02-01 20:16 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  1 Feb 2017 16:34:49 +0200, Baruch Siach wrote:
> There is no status() shell routine in this script.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

I think status() here was not necessarily meant to be a shell function.
Maybe it's supposed to be the status program, which is part of Upstart,
and allows to query the status of a service.

But since we don't use Upstart, it's indeed not going to work. Just
that your commit log is probably not 100% correct.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-01 20:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 14:34 [Buildroot] [PATCH] dbus: remove init script status op Baruch Siach
2017-02-01 20:16 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox