From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] core infra: make sure apply-patches is called with correct tar
Date: Wed, 1 Feb 2017 22:11:18 +0100 [thread overview]
Message-ID: <20170201221118.6cda53d9@free-electrons.com> (raw)
In-Reply-To: <20170201112708.17709-1-patrickdepinguin@gmail.com>
Hello,
On Wed, 1 Feb 2017 12:27:08 +0100, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> Buildroot has a mechanism to detect a too-old or missing tar program on the
> host machine, and builds a custom host-tar if needed. An example situation
> is a RHEL5 host machine, where tar is knowingly too old.
>
> The apply-patches script also employs tar, in case the patches come as an
> archive. However, tar is called as 'tar' without any absolute path, and the
> environment does not point in any way to the possibly custom tar. As a
> result, the too-old-tar is called. A particular problem is the flag '-a'
> which is missing on e.g. RHEL5.
>
> Previously, this problem went unnoticed: tar would fail, but apply-patches
> did not notice it, and the overall return code of the script was 'success'.
> However, commit d5ae67b4 added 'set -e' to the script, causing any error to
> halt execution of the script with an error.
>
> Fix the problem by adding the Buildroot-built host tools to the PATH when
> calling apply-patches.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-02-01 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 11:27 [Buildroot] [PATCH 1/1] core infra: make sure apply-patches is called with correct tar Thomas De Schampheleire
2017-02-01 21:11 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201221118.6cda53d9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox