[Buildroot] [PATCH 1/1] libcurl: optional verbose strings config

[Buildroot] [PATCH 1/1] libcurl: optional verbose strings config

[Matt Weber]

From: Judd Meinders <judd.meinders@rockwellcollins.com>

This patch enables a config to set --enable-verbose during the
configuration of libcurl.  The option is triggered by setting
BR2_PACKAGE_LIBCURL_VERBOSE.

Signed-off-by: Judd Meinders <judd.meinders@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/libcurl/Config.in  | 5 +++++
 package/libcurl/libcurl.mk | 9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/package/libcurl/Config.in b/package/libcurl/Config.in
index 026ae01..fc1527f 100644
--- a/package/libcurl/Config.in
+++ b/package/libcurl/Config.in
@@ -13,4 +13,9 @@ config BR2_PACKAGE_CURL
 	help
 	  Install curl binary as well
 
+config BR2_PACKAGE_LIBCURL_VERBOSE
+	bool "enable verbose strings"
+	help
+	  Enable verbose text strings
+
 endif
diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
index ea37309..e901a85 100644
--- a/package/libcurl/libcurl.mk
+++ b/package/libcurl/libcurl.mk
@@ -19,8 +19,15 @@ LIBCURL_INSTALL_STAGING = YES
 # on non-MMU platforms. Moreover, this authentication method is
 # probably almost never used. See
 # http://curl.haxx.se/docs/manpage.html#--ntlm.
-LIBCURL_CONF_OPTS = --disable-verbose --disable-manual --disable-ntlm-wb \
+LIBCURL_CONF_OPTS = --disable-manual --disable-ntlm-wb \
 	--enable-hidden-symbols --with-random=/dev/urandom --disable-curldebug
+
+# Make verbose strings optional via config
+ifeq ($(BR2_PACKAGE_LIBCURL_VERBOSE),y)
+LIBCURL_CONF_OPTS += --enable-verbose
+else
+LIBCURL_CONF_OPTS += --disable-verbose
+endif
 LIBCURL_CONFIG_SCRIPTS = curl-config
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-- 
1.9.1

[Buildroot] [PATCH 1/1] libcurl: optional verbose strings config

[Thomas Petazzoni]

Hello,

On Tue, 31 Jan 2017 11:26:53 -0600, Matt Weber wrote:
> From: Judd Meinders <judd.meinders@rockwellcollins.com>
> 
> This patch enables a config to set --enable-verbose during the
> configuration of libcurl.  The option is triggered by setting
> BR2_PACKAGE_LIBCURL_VERBOSE.
> 
> Signed-off-by: Judd Meinders <judd.meinders@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/libcurl/Config.in  | 5 +++++
>  package/libcurl/libcurl.mk | 9 ++++++++-
>  2 files changed, 13 insertions(+), 1 deletion(-)

There's only a 22 KB difference between verbose and non-verbose, so I
wasn't entirely sure a new sub-option was needed. But well, it's still
22 KB, so I've applied your patch. We'll see if others complain about
the additional sub-option for such a small size difference.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libcurl: optional verbose strings config

[Thomas Petazzoni]

Hello,

On Wed, 1 Feb 2017 15:15:20 -0600, Judd Meinders wrote:

> The original (and still) default selection of libcurl uses
> --disable-verbose so the new sub option is meant to merely provide the
> availability to include the verbose output as a library feature.  I
> wasn't thinking target size I guess.

My point was that if the size increase caused by --enable-verbose was
really small, then having a Buildroot sub-option just for this would
really be pointless.

More config options in Buildroot means more complexity, more
combinations of configurations, and therefore more chances for things
to break. Hence we always think twice about adding new configuration
options.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com