[Buildroot] [PATCH 1/1] automake: fix unescaped left brace warning patch.

[Buildroot] [PATCH 1/1] automake: fix unescaped left brace warning patch.

[Adam Duskett]

Automake currently has a unescaped left brace in it's automake.in folder
that generates the warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes this warning.

Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
---
 .../0002-fix-unescaped-left-brace-warning.patch       | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/automake/0002-fix-unescaped-left-brace-warning.patch

diff --git a/package/automake/0002-fix-unescaped-left-brace-warning.patch b/package/automake/0002-fix-unescaped-left-brace-warning.patch
new file mode 100644
index 0000000..a33b1f1
--- /dev/null
+++ b/package/automake/0002-fix-unescaped-left-brace-warning.patch
@@ -0,0 +1,19 @@
+Automake currently has a unescaped left brace in it's automake.in folder
+that generates the warning:
+Unescaped left brace in regex is deprecated, passed through in regex;
+This patch fixes this warning.
+
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+
+diff -Naur a/bin/automake.in b/bin/automake.in
+--- a/bin/automake.in	2015-01-05 14:25:55.000000000 -0500
++++ b/bin/automake.in	2017-02-08 18:59:24.963611569 -0500
+@@ -3878,7 +3878,7 @@
+ sub substitute_ac_subst_variables
+ {
+   my ($text) = @_;
+-  $text =~ s/\${([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
++  $text =~ s/\$\{([^ \t=:+{}]+)\}/substitute_ac_subst_variables_worker ($1)/ge;
+   return $text;
+ }
+
-- 
2.9.3

[Buildroot] [PATCH 1/1] automake: fix unescaped left brace warning patch.

[Thomas Petazzoni]

Hello,

On Wed,  8 Feb 2017 19:07:10 -0500, Adam Duskett wrote:

>  .../0002-fix-unescaped-left-brace-warning.patch       | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 package/automake/0002-fix-unescaped-left-brace-warning.patch
> 
> diff --git a/package/automake/0002-fix-unescaped-left-brace-warning.patch b/package/automake/0002-fix-unescaped-left-brace-warning.patch
> new file mode 100644
> index 0000000..a33b1f1
> --- /dev/null
> +++ b/package/automake/0002-fix-unescaped-left-brace-warning.patch
> @@ -0,0 +1,19 @@
> +Automake currently has a unescaped left brace in it's automake.in folder
> +that generates the warning:
> +Unescaped left brace in regex is deprecated, passed through in regex;
> +This patch fixes this warning.
> +
> +Signed-off-by: Adam Duskett <aduskett@gmail.com>

I am *really* uncomfortable about merging patches touching the automake
code base if those patches are not upstream. So please submit this
upstream, and if it gets accepted, then we can integrate it in
Buildroot.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] automake: fix unescaped left brace warning patch.

[Adam Duskett]

Hello;

On Thu, Feb 9, 2017 at 3:41 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Wed,  8 Feb 2017 19:07:10 -0500, Adam Duskett wrote:
>
>>  .../0002-fix-unescaped-left-brace-warning.patch       | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>  create mode 100644 package/automake/0002-fix-unescaped-left-brace-warning.patch
>>
>> diff --git a/package/automake/0002-fix-unescaped-left-brace-warning.patch b/package/automake/0002-fix-unescaped-left-brace-warning.patch
>> new file mode 100644
>> index 0000000..a33b1f1
>> --- /dev/null
>> +++ b/package/automake/0002-fix-unescaped-left-brace-warning.patch
>> @@ -0,0 +1,19 @@
>> +Automake currently has a unescaped left brace in it's automake.in folder
>> +that generates the warning:
>> +Unescaped left brace in regex is deprecated, passed through in regex;
>> +This patch fixes this warning.
>> +
>> +Signed-off-by: Adam Duskett <aduskett@gmail.com>
>
> I am *really* uncomfortable about merging patches touching the automake
> code base if those patches are not upstream. So please submit this
> upstream, and if it gets accepted, then we can integrate it in
> Buildroot.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Huh, looks like it was submitted and accepted into their git
repository.  I didn't even notice!
http://git.savannah.gnu.org/cgit/automake.git/commit/?id=13f00eb4493c217269b76614759e452d8302955e

[Buildroot] [PATCH 1/1] automake: fix unescaped left brace warning patch.

[Thomas Petazzoni]

Hello,

On Thu, 9 Feb 2017 07:33:26 -0500, Adam Duskett wrote:

> Huh, looks like it was submitted and accepted into their git
> repository.  I didn't even notice!
> http://git.savannah.gnu.org/cgit/automake.git/commit/?id=13f00eb4493c217269b76614759e452d8302955e

OK. Then please backport this upstreaming commit, and submit it as a
Buildroot patch. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com