Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/efl: enable Wayland support if available
Date: Thu, 9 Feb 2017 23:19:09 +0100	[thread overview]
Message-ID: <20170209231909.025f4312@free-electrons.com> (raw)
In-Reply-To: <20170206162437.12748-1-romain.naour@gmail.com>

Hello,

On Mon,  6 Feb 2017 17:24:37 +0100, Romain Naour wrote:
> If all the dependencies are present to select the efl wayland
> support, enable it by default.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> v2: rebase on master
> ---
>  package/efl/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 5e89af6..a8f9d41 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -180,6 +180,7 @@ config BR2_PACKAGE_EFL_WAYLAND
>  	depends on BR2_PACKAGE_EFL_EEZE # efl drm
>  	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
>  	select BR2_PACKAGE_EFL_DRM
> +	default y

Why would we do this? For the X.org support, we also have a "depends
on" and the option is not "default y". I don't see why the X.org and
Wayland cases should be handled differently. If there is a reason, it
should be explained in the commit log IMO.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-02-09 22:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 16:24 [Buildroot] [PATCH v2] package/efl: enable Wayland support if available Romain Naour
2017-02-09 22:19 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209231909.025f4312@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox