Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/efl: enable Wayland support if available
@ 2017-02-06 16:24 Romain Naour
  2017-02-09 22:19 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2017-02-06 16:24 UTC (permalink / raw)
  To: buildroot

If all the dependencies are present to select the efl wayland
support, enable it by default.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
v2: rebase on master
---
 package/efl/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 5e89af6..a8f9d41 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -180,6 +180,7 @@ config BR2_PACKAGE_EFL_WAYLAND
 	depends on BR2_PACKAGE_EFL_EEZE # efl drm
 	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
 	select BR2_PACKAGE_EFL_DRM
+	default y
 
 comment "Wayland support needs udev /dev management (eeze) and OpenGL ES w/ EGL, threads"
 	depends on BR2_PACKAGE_WAYLAND
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] package/efl: enable Wayland support if available
  2017-02-06 16:24 [Buildroot] [PATCH v2] package/efl: enable Wayland support if available Romain Naour
@ 2017-02-09 22:19 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-02-09 22:19 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  6 Feb 2017 17:24:37 +0100, Romain Naour wrote:
> If all the dependencies are present to select the efl wayland
> support, enable it by default.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> v2: rebase on master
> ---
>  package/efl/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 5e89af6..a8f9d41 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -180,6 +180,7 @@ config BR2_PACKAGE_EFL_WAYLAND
>  	depends on BR2_PACKAGE_EFL_EEZE # efl drm
>  	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
>  	select BR2_PACKAGE_EFL_DRM
> +	default y

Why would we do this? For the X.org support, we also have a "depends
on" and the option is not "default y". I don't see why the X.org and
Wayland cases should be handled differently. If there is a reason, it
should be explained in the commit log IMO.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-09 22:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-06 16:24 [Buildroot] [PATCH v2] package/efl: enable Wayland support if available Romain Naour
2017-02-09 22:19 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox