[Buildroot] [PATCH v5] gtest/gmock: bump to version 1.8.0

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

(It would be nice to strip the irrelevant part of an e-mail when
replying, so that one doesn't have to scroll through a huge e-mail just
to find one comment lost in the middle of the reply. Thanks!)

On Sun, 12 Feb 2017 15:15:17 +0100, Romain Naour wrote:

> > +# By default, build gmock and gtest
> > +ifeq ($(BR2_PACKAGE_GTEST_GMOCK),)
> > +GTEST_CONF_OPTS = -DBUILD_GTEST=ON -DBUILD_GMOCK=OFF
> > +endif  
> 
> Here, if BR2_PACKAGE_GTEST_GMOCK is not set -DBUILD_SHARED_LIBS=OFF will be
> dropped from GTEST_CONF_OPTS.
> 
> You should use += here:
> GTEST_CONF_OPTS += -DBUILD_GTEST=ON -DBUILD_GMOCK=OFF
> 
> Otherwise shared libraries will be build:
> 
> ./googletest/libgtest_main.so
> ./googletest/libgtest.so
> 
> Maybe it's something that can be fixed while merging this patch?

Also, why is -BUILD_GTEST=on only passed when GMock is disabled?

I would have assumed something more like this:

GTEST_CONF_OPTS += -DBUILD_GTEST=ON

ifeq ($(BR2_PACKAGE_GTEST_GMOCK),y)
GTEST_CONF_OPTS += -DBUILD_GMOCK=ON
else
GTEST_CONF_OPTS += -DBUILD_GMOCK=OFF
endif

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com