* [Buildroot] [PATCH v2] package/x11r7/xserver_xorg-server: Add patch to fix v1.19.1 with SIGIO
@ 2017-02-15 17:12 Mylène Josserand
2017-02-15 20:26 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Mylène Josserand @ 2017-02-15 17:12 UTC (permalink / raw)
To: buildroot
The commit 6a5a4e60373c from xserver v1.19.1 removes SIGIO support for
input [1].
The current patch coming from Open Embedded [2] removes a check of
'useSIGIO'. This check was producing a segfault error while using
X11 and Vivante driver [3]. Thanks to Gary Bisson to point out this
patch!
[1] https://cgit.freedesktop.org/xorg/xserver/commit/?id=6a5a4e60373c1386b311b2a8bb666c32d68a9d99
[2] https://patchwork.openembedded.org/patch/136696/
[3] http://lists.busybox.net/pipermail/buildroot/2017-February/183994.html
Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
---
.../0003-Remove-check-for-useSIGIO-option.patch | 53 ++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 package/x11r7/xserver_xorg-server/1.19.1/0003-Remove-check-for-useSIGIO-option.patch
diff --git a/package/x11r7/xserver_xorg-server/1.19.1/0003-Remove-check-for-useSIGIO-option.patch b/package/x11r7/xserver_xorg-server/1.19.1/0003-Remove-check-for-useSIGIO-option.patch
new file mode 100644
index 000000000..d4f0cca67
--- /dev/null
+++ b/package/x11r7/xserver_xorg-server/1.19.1/0003-Remove-check-for-useSIGIO-option.patch
@@ -0,0 +1,53 @@
+From cf407b16cd65ad6e26a9c8e5984e163409a5c0f7 Mon Sep 17 00:00:00 2001
+From: Prabhu Sundararaj <prabhu.sundararaj@nxp.com>
+Date: Mon, 30 Jan 2017 16:32:06 -0600
+Subject: [PATCH] Remove check for useSIGIO option
+
+Original patch follows:
+Commit 6a5a4e60373c1386b311b2a8bb666c32d68a9d99 removes the configure of useSIGIO
+option.
+
+As the xfree86 SIGIO support is reworked to use internal versions of OsBlockSIGIO
+and OsReleaseSIGIO.
+
+No longer the check for useSIGIO is needed
+
+Upstream-Status: Pending
+
+Signed-off-by: Prabhu Sundararaj <prabhu.sundararaj@nxp.com>
+
+Downloaded from
+https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-Remove-check-for-useSIGIO-option.patch
+
+Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
+---
+ hw/xfree86/os-support/shared/sigio.c | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/hw/xfree86/os-support/shared/sigio.c b/hw/xfree86/os-support/shared/sigio.c
+index 884a71c..be76498 100644
+--- a/hw/xfree86/os-support/shared/sigio.c
++++ b/hw/xfree86/os-support/shared/sigio.c
+@@ -185,9 +185,6 @@ xf86InstallSIGIOHandler(int fd, void (*f) (int, void *), void *closure)
+ int i;
+ int installed = FALSE;
+
+- if (!xf86Info.useSIGIO)
+- return 0;
+-
+ for (i = 0; i < MAX_FUNCS; i++) {
+ if (!xf86SigIOFuncs[i].f) {
+ if (xf86IsPipe(fd))
+@@ -256,9 +253,6 @@ xf86RemoveSIGIOHandler(int fd)
+ int max;
+ int ret;
+
+- if (!xf86Info.useSIGIO)
+- return 0;
+-
+ max = 0;
+ ret = 0;
+ for (i = 0; i < MAX_FUNCS; i++) {
+--
+2.7.4
+
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2] package/x11r7/xserver_xorg-server: Add patch to fix v1.19.1 with SIGIO
2017-02-15 17:12 [Buildroot] [PATCH v2] package/x11r7/xserver_xorg-server: Add patch to fix v1.19.1 with SIGIO Mylène Josserand
@ 2017-02-15 20:26 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-02-15 20:26 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 15 Feb 2017 18:12:16 +0100, Myl?ne Josserand wrote:
> The commit 6a5a4e60373c from xserver v1.19.1 removes SIGIO support for
> input [1].
>
> The current patch coming from Open Embedded [2] removes a check of
> 'useSIGIO'. This check was producing a segfault error while using
> X11 and Vivante driver [3]. Thanks to Gary Bisson to point out this
> patch!
>
> [1] https://cgit.freedesktop.org/xorg/xserver/commit/?id=6a5a4e60373c1386b311b2a8bb666c32d68a9d99
> [2] https://patchwork.openembedded.org/patch/136696/
> [3] http://lists.busybox.net/pipermail/buildroot/2017-February/183994.html
>
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
> ---
> .../0003-Remove-check-for-useSIGIO-option.patch | 53 ++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 package/x11r7/xserver_xorg-server/1.19.1/0003-Remove-check-for-useSIGIO-option.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-15 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-15 17:12 [Buildroot] [PATCH v2] package/x11r7/xserver_xorg-server: Add patch to fix v1.19.1 with SIGIO Mylène Josserand
2017-02-15 20:26 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox