* [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on
@ 2017-02-23 19:44 Gustavo Zacarias
2017-02-23 21:22 ` Thomas Petazzoni
2017-02-23 21:23 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2017-02-23 19:44 UTC (permalink / raw)
To: buildroot
Trying to copy loaders.cache from host-gdk-pixbuf to the gdk-pixbuf
build directory in the post-patch hook is too early when using TLP (it
breaks horribly) since host-gdk-pixbuf isn't built yet during the
massive unpack/patch cycle.
Switch it to the pre-build hook instead which ensures that gdk-pixbuf
dependencies were already built.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/gdk-pixbuf/gdk-pixbuf.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
index e4d3658..0f4eeb1 100644
--- a/package/gdk-pixbuf/gdk-pixbuf.mk
+++ b/package/gdk-pixbuf/gdk-pixbuf.mk
@@ -80,7 +80,7 @@ define GDK_PIXBUF_COPY_LOADERS_CACHE
cp -f $(HOST_DIR)/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache \
$(@D)/gdk-pixbuf
endef
-GDK_PIXBUF_POST_PATCH_HOOKS += GDK_PIXBUF_COPY_LOADERS_CACHE
+GDK_PIXBUF_PRE_BUILD_HOOKS += GDK_PIXBUF_COPY_LOADERS_CACHE
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on
2017-02-23 19:44 [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on Gustavo Zacarias
@ 2017-02-23 21:22 ` Thomas Petazzoni
2017-02-23 21:31 ` Thomas Petazzoni
2017-02-23 21:23 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-02-23 21:22 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 23 Feb 2017 16:44:48 -0300, Gustavo Zacarias wrote:
> Trying to copy loaders.cache from host-gdk-pixbuf to the gdk-pixbuf
> build directory in the post-patch hook is too early when using TLP (it
> breaks horribly) since host-gdk-pixbuf isn't built yet during the
> massive unpack/patch cycle.
> Switch it to the pre-build hook instead which ensures that gdk-pixbuf
> dependencies were already built.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Since the first pat
> ---
> package/gdk-pixbuf/gdk-pixbuf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
> index e4d3658..0f4eeb1 100644
> --- a/package/gdk-pixbuf/gdk-pixbuf.mk
> +++ b/package/gdk-pixbuf/gdk-pixbuf.mk
> @@ -80,7 +80,7 @@ define GDK_PIXBUF_COPY_LOADERS_CACHE
> cp -f $(HOST_DIR)/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache \
> $(@D)/gdk-pixbuf
> endef
> -GDK_PIXBUF_POST_PATCH_HOOKS += GDK_PIXBUF_COPY_LOADERS_CACHE
> +GDK_PIXBUF_PRE_BUILD_HOOKS += GDK_PIXBUF_COPY_LOADERS_CACHE
>
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on
2017-02-23 19:44 [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on Gustavo Zacarias
2017-02-23 21:22 ` Thomas Petazzoni
@ 2017-02-23 21:23 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-02-23 21:23 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 23 Feb 2017 16:44:48 -0300, Gustavo Zacarias wrote:
> Trying to copy loaders.cache from host-gdk-pixbuf to the gdk-pixbuf
> build directory in the post-patch hook is too early when using TLP (it
> breaks horribly) since host-gdk-pixbuf isn't built yet during the
> massive unpack/patch cycle.
> Switch it to the pre-build hook instead which ensures that gdk-pixbuf
> dependencies were already built.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/gdk-pixbuf/gdk-pixbuf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on
2017-02-23 21:22 ` Thomas Petazzoni
@ 2017-02-23 21:31 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-02-23 21:31 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 23 Feb 2017 22:22:56 +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 23 Feb 2017 16:44:48 -0300, Gustavo Zacarias wrote:
> > Trying to copy loaders.cache from host-gdk-pixbuf to the gdk-pixbuf
> > build directory in the post-patch hook is too early when using TLP (it
> > breaks horribly) since host-gdk-pixbuf isn't built yet during the
> > massive unpack/patch cycle.
> > Switch it to the pre-build hook instead which ensures that gdk-pixbuf
> > dependencies were already built.
> >
> > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
>
> Since the first pat
Sorry for this e-mail sent by mistake.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-23 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 19:44 [Buildroot] [PATCH next] gdk-pixbuf: copy loaders.cache later on Gustavo Zacarias
2017-02-23 21:22 ` Thomas Petazzoni
2017-02-23 21:31 ` Thomas Petazzoni
2017-02-23 21:23 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox