From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/alsamixergui: add license information
Date: Thu, 2 Mar 2017 21:37:41 +0100 [thread overview]
Message-ID: <20170302213741.63b86f2a@free-electrons.com> (raw)
In-Reply-To: <c6240c78-d0ee-a3c8-681a-b041f963f72c@grandegger.com>
Hello,
Please keep the Buildroot mailing list in Cc. Thanks!
On Thu, 2 Mar 2017 18:28:08 +0100, Wolfgang Grandegger wrote:
> "make legal-info" did report that the license is unkown.
Yes, before your patch. What I suggested is that you should run "make
legal-info" after your patch.
> Then I looked
> into "build/alsamixergui...". The COPYING file seems to be generated by make:
>
> $ make alsamixergui-dirclean
> $ make alsamixergui-extract
> $ head build/alsamixergui-0.9.0rc2-1/COPYING
> head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory
> $ make alsamixergui
> $ head build/alsamixergui-0.9.0rc2-1/COPYING
OK, but that doesn't work, because you have no guarantee that the
package has been built when "make legal-info" runs. "make legal-info"
only ensures that packages have been: 1. downloaded, 2. extracted, 3.
patched.
So, with your patch applied, if you run:
$ make clean
$ make legal-info
then you will see that it fails, because the COPYING file doesn't exist.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-02 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:06 [Buildroot] [PATCH] package/alsamixergui: add license information Wolfgang Grandegger
2017-03-02 16:16 ` Thomas Petazzoni
[not found] ` <c6240c78-d0ee-a3c8-681a-b041f963f72c@grandegger.com>
2017-03-02 20:37 ` Thomas Petazzoni [this message]
2017-03-03 7:34 ` Wolfgang Grandegger
2017-03-03 7:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302213741.63b86f2a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox